pixiv: fix failure to upload bad pixiv id images (fix #4031)

Bug: Uploading bad pixiv id images failed because the pixiv strategy
raised a BadIDError exception when the upload service checked for the
ugoira frame data.

app/logical/sources/strategies/pixiv.rb

@@ -326,6 +326,8 @@ module Sources
         end
 
         return metadata.moniker
+      rescue PixivApiClient::BadIDError
+        nil
       end
       memoize :moniker
 
@@ -344,6 +346,8 @@ module Sources
 
       def ugoira_frame_data
         return metadata.json.dig("metadata", "frames")
+      rescue PixivApiClient::BadIDError
+        nil
       end
       memoize :ugoira_frame_data
 

app/logical/upload_service/utils.rb

@@ -229,7 +229,7 @@ class UploadService
         retry
       end
 
-      if download.data[:ugoira_frame_data]
+      if download.data[:ugoira_frame_data].present?
         upload.context = { 
           "ugoira" => {
             "frame_data" => download.data[:ugoira_frame_data],