From 055d0eecd3851450b5e977a484887812c1020e09 Mon Sep 17 00:00:00 2001 From: Toks Date: Wed, 30 Apr 2014 21:18:18 -0400 Subject: [PATCH] Remove redundant promoter name from user feedback Feedbacks already keep track of who created them so it doesn't need to be in the body too --- app/logical/user_promotion.rb | 2 +- test/unit/user_test.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/logical/user_promotion.rb b/app/logical/user_promotion.rb index a8544c47b..15f01db8c 100644 --- a/app/logical/user_promotion.rb +++ b/app/logical/user_promotion.rb @@ -48,7 +48,7 @@ private user.feedback.create( :category => "neutral", - :body => "#{body_prefix} by #{promoter.name} from #{user.level_string_was} to #{user.level_string}", + :body => "#{body_prefix} from #{user.level_string_was} to #{user.level_string}", :disable_dmail_notification => true ) end diff --git a/test/unit/user_test.rb b/test/unit/user_test.rb index 6e2da3087..6c9d382c1 100644 --- a/test/unit/user_test.rb +++ b/test/unit/user_test.rb @@ -30,7 +30,7 @@ class UserTest < ActiveSupport::TestCase @user.promote_to!(User::Levels::GOLD) end - assert_equal("Promoted by #{CurrentUser.user.name} from Member to Gold", @user.feedback.last.body) + assert_equal("Promoted from Member to Gold", @user.feedback.last.body) end should "create a dmail" do