jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

migrations: fix old migration not removing posts.uploader_ip_addr index.

Browse Source 
Bug: running migrations on a fresh database failed when we got to a
migration adding a posts.uploader_ip_addr index on 2019-11-11. It failed
because the index already existed.

The index already existed because we used to have it at one point, until
it was removed by another migration on 2015-01-20. This migration didn't
correctly remove the index though, because it tried to remove a
posts.source index first, which failed because this index didn't exist
(it probably existed only in production). This error was swallowed,
causing the migration to silently skip removing the posts.uploader_ip_addr
index, which eventually blew up when we tried to add the index again
later on.
This commit is contained in:
evazion
2019-11-13 01:54:04 -06:00
parent 378559ff47
commit 0726e4346a
1 changed files with 2 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
db/migrate/20150120005624_remove_unused_indexes.rb
View File

@@ -1,10 +1,7 @@
class RemoveUnusedIndexes < ActiveRecord::Migration[4.2] class RemoveUnusedIndexes < ActiveRecord::Migration[4.2]
def change def change
execute "set statement_timeout = 0" execute "set statement_timeout = 0"
begin #remove_index :posts, :source
remove_index :posts, :source remove_index :posts, :uploader_ip_addr
remove_index :posts, :uploader_ip_addr
rescue ArgumentError
end
end end
end end