jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Pixiv: don't add auto-generated usernames to the other names field

Browse Source
This commit is contained in:
nonamethanks
2021-03-16 02:43:02 +01:00
parent 0249c290fd
commit 073f63cfa7
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/logical/sources/strategies/pixiv.rb
View File

@@ -162,7 +162,9 @@ module Sources
end end
def other_names def other_names
[artist_name, moniker].compact.uniq other_names = [artist_name]
other_names << moniker unless moniker&.starts_with?("user_")
other_names.compact.uniq
end end
def artist_commentary_title def artist_commentary_title

5
test/unit/sources/pixiv_test.rb
View File

@@ -303,6 +303,11 @@ module Sources
assert_includes(source.profile_urls, "https://www.pixiv.net/users/696859") assert_includes(source.profile_urls, "https://www.pixiv.net/users/696859")
assert_includes(source.profile_urls, "https://www.pixiv.net/stacc/uroobnad") assert_includes(source.profile_urls, "https://www.pixiv.net/stacc/uroobnad")
end end
should "not add pixiv-generated 'user_' usernames to the other names field" do
source = get_source("https://www.pixiv.net/en/artworks/88487025")
assert_equal(["éé"], source.other_names)
end
end end
context "parsing illust ids" do context "parsing illust ids" do