rubocop: fix various Rubocop warnings.

2021-06-16 18:24:42 -05:00
parent cfe471e0b5
commit 07e23204b6
99 changed files with 412 additions and 374 deletions
--- a/app/helpers/post_versions_helper.rb
+++ b/app/helpers/post_versions_helper.rb
@@ -40,12 +40,12 @@ module PostVersionsHelper
  def post_version_field(post_version, field)
    value = post_version_value(post_version.send(field))
    prefix = (field == :parent_id ? "parent" : field.to_s)
-    search = prefix + ":" + value.to_s
+    search = "#{prefix}:#{value}"
    display = (field == :rating ? post_version.pretty_rating : value)
    %(<b>#{field.to_s.titleize}:</b> #{link_to(display, posts_path(:tags => search))}).html_safe
  end

  def post_version_value(value)
-    return (value.present? ? value : "none")
+    value.presence || "none"
  end
 end