From 087ce001e78ea78d7d120494ac728c663a00cd3d Mon Sep 17 00:00:00 2001 From: evazion Date: Sun, 7 May 2017 09:53:13 -0500 Subject: [PATCH] user name changes: don't force new name to lowercase. --- app/models/user_name_change_request.rb | 4 ---- test/factories/user_name_change_request.rb | 6 ++++++ test/unit/user_name_change_request_test.rb | 7 +++++++ 3 files changed, 13 insertions(+), 4 deletions(-) create mode 100644 test/factories/user_name_change_request.rb diff --git a/app/models/user_name_change_request.rb b/app/models/user_name_change_request.rb index b7de494f9..680f55529 100644 --- a/app/models/user_name_change_request.rb +++ b/app/models/user_name_change_request.rb @@ -37,10 +37,6 @@ class UserNameChangeRequest < ActiveRecord::Base status == "pending" end - def desired_name=(name) - super(User.normalize_name(name)) - end - def feedback UserFeedback.for_user(user_id).order("id desc") end diff --git a/test/factories/user_name_change_request.rb b/test/factories/user_name_change_request.rb new file mode 100644 index 000000000..af0f42124 --- /dev/null +++ b/test/factories/user_name_change_request.rb @@ -0,0 +1,6 @@ +FactoryGirl.define do + factory(:user_name_change_request) do + desired_name {FFaker::Internet.user_name} + change_reason {FFaker::Lorem.sentence} + end +end diff --git a/test/unit/user_name_change_request_test.rb b/test/unit/user_name_change_request_test.rb index 1a62a4b54..1d4fb3a02 100644 --- a/test/unit/user_name_change_request_test.rb +++ b/test/unit/user_name_change_request_test.rb @@ -91,6 +91,13 @@ class UserNameChangeRequestTest < ActiveSupport::TestCase assert_equal(["Desired name already exists"], req.errors.full_messages) end end + + should "not convert the desired name to lower case" do + uncr = FactoryGirl.create(:user_name_change_request, user: @requester, original_name: "provence.", desired_name: "Provence") + CurrentUser.scoped(@admin) { uncr.approve! } + + assert_equal("Provence", @requester.name) + end end end end