jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Add Danbooru::Archive library for handling .zip and .rar files.

Browse Source 
Introduce a new Danbooru::Archive library. This is a wrapper around libarchive that lets us extract
.zip, .rar, .7z, and other archive formats. Replace the rubyzip library in MediaFile::Ugoira with
the new Danbooru::Archive library.

This is a step towards fixing #5340: Add support for extracting archive attachments from certain sources.

This adds a new dependency on libarchive. Downstream users should `apt-get install libarchive13` if
they're not using Docker.

https://github.com/chef/ffi-libarchive
https://github.com/libarchive/libarchive
https://www.rubydoc.info/gems/ffi-libarchive/0.4.2
https://github.com/libarchive/libarchive/wiki/Examples#a-complete-extractor
This commit is contained in:
evazion
2022-11-14 13:36:09 -06:00
parent f942768ce8
commit 0c1e9a1618
6 changed files with 361 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

111
test/unit/danbooru_archive_test.rb Normal file
View File

@@ -0,0 +1,111 @@
require 'test_helper'
class DanbooruArchiveTest < ActiveSupport::TestCase
context "Danbooru::Archive" do
context ".open! method" do
should "work without a block" do
archive = Danbooru::Archive.open!("test/files/ugoira.zip")
assert_equal(5, archive.entries.count)
end
should "work with a block" do
Danbooru::Archive.open!("test/files/ugoira.zip") do |archive|
assert_equal(5, archive.entries.count)
end
end
should "raise an error if the block raises an error" do
assert_raises(Danbooru::Archive::Error) { Danbooru::Archive.open!("test/files/ugoira.zip") { raise "failed" } }
end
should "raise an error if the file doesn't exist" do
assert_raises(Danbooru::Archive::Error) { Danbooru::Archive.open!("test/files/does_not_exist.zip") }
end
end
context ".open method" do
should "work without a block" do
archive = Danbooru::Archive.open("test/files/ugoira.zip")
assert_equal(5, archive.entries.count)
end
should "work with a block" do
Danbooru::Archive.open("test/files/ugoira.zip") do |archive|
assert_equal(5, archive.entries.count)
end
end
should "return nil if the block raises an error" do
assert_nil(Danbooru::Archive.open("test/files/ugoira.zip") { raise "failed" })
end
should "return nil if the file doesn't exist" do
assert_nil(Danbooru::Archive.open("test/files/does_not_exist.zip"))
end
end
context ".extract! method" do
should "extract to temp directory if not given a block or directory" do
dir, filenames = Danbooru::Archive.extract!("test/files/ugoira.zip")
assert_equal(true, File.directory?(dir))
assert_equal(5, filenames.size)
filenames.each { |filename| assert_equal(true, File.exist?(filename)) }
ensure
FileUtils.rm_rf(dir)
end
should "extract to a temp directory and delete it afterwards if given a block" do
Danbooru::Archive.extract!("test/files/ugoira.zip") do |dir, filenames|
@tmpdir = dir
assert_equal(true, File.directory?(dir))
assert_equal(5, filenames.size)
filenames.each { |filename| assert_equal(true, File.exist?(filename)) }
end
assert_equal(true, @tmpdir.present?)
assert_equal(false, File.exist?(@tmpdir))
end
should "extract to given directory if given a directory" do
Dir.mktmpdir do |tmpdir|
dir, filenames = Danbooru::Archive.extract!("test/files/ugoira.zip", tmpdir)
assert_equal(dir, tmpdir)
assert_equal(5, filenames.size)
filenames.each { |filename| assert_equal(true, File.exist?(filename)) }
end
end
end
context "#uncompressed_size method" do
should "work" do
archive = Danbooru::Archive.open!("test/files/ugoira.zip")
assert_equal(6161, archive.uncompressed_size)
end
end
context "#exists? method" do
should "work" do
archive = Danbooru::Archive.open!("test/files/ugoira.zip")
assert_equal(true, archive.exists? { |entry, count| count > 4 })
end
end
context "#format method" do
should "work" do
archive = Danbooru::Archive.open!("test/files/ugoira.zip")
assert_equal("ZIP 2.0 (uncompressed)", archive.format)
end
end
context "#ls method" do
should "work" do
archive = Danbooru::Archive.open!("test/files/ugoira.zip")
output = StringIO.new
archive.ls(output)
assert_match(/^-rw-rw-r-- *0 0 *1639 2014-10-05 23:31:06 000000\.jpg$/, output.tap(&:rewind).read)
end
end
end
end