From 0d680a4a45cfd415bc49c94e2d1e5acdbfaba9b9 Mon Sep 17 00:00:00 2001 From: xiaody Date: Thu, 15 Aug 2013 01:09:59 +0800 Subject: [PATCH] Safer $.fn.selectEnd When `this.length` is 0, `this.val().length` will become `undefined.length` and cause a TypeError. --- app/assets/javascripts/utility.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/app/assets/javascripts/utility.js b/app/assets/javascripts/utility.js index afd8db9bc..903ab21f2 100644 --- a/app/assets/javascripts/utility.js +++ b/app/assets/javascripts/utility.js @@ -102,7 +102,9 @@ }; $.fn.selectEnd = function(){ - this.selectRange(this.val().length, this.val().length); + if (this.length) { + this.selectRange(this.val().length, this.val().length); + } return this; } })();