jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Replace deprecated update_attributes with update.

Browse Source 
https://rubyinrails.com/2019/04/09/rails-6-1-activerecord-deprecates-update-attributes-methods/

DEPRECATION WARNING: update_attributes! is deprecated and will be removed from Rails 6.1 (please, use update! instead)
This commit is contained in:
evazion
2019-08-25 20:29:32 -05:00
parent 62875eabb2
commit 0df5c0fd2b
23 changed files with 63 additions and 87 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
test/unit/note_test.rb
View File

@@ -20,7 +20,7 @@ class NoteTest < ActiveSupport::TestCase
end
should "not increment version" do
@note.update_attributes(:x => 100)
@note.update(x: 100)
assert_equal(1, @note.versions.count)
assert_equal(1, @note.versions.first.version)
end
@@ -121,14 +121,14 @@ class NoteTest < ActiveSupport::TestCase
should "increment the updater's note_update_count" do
@user.reload
assert_difference("@user.note_update_count", 1) do
@note.update_attributes(:body => "zzz")
@note.update(body: "zzz")
@user.reload
end
end
should "update the post's last_noted_at field" do
assert_nil(@post.last_noted_at)
@note.update_attributes(:x => 500)
@note.update(x: 500)
@post.reload
assert_equal(@post.last_noted_at.to_i, @note.updated_at.to_i)
end
@@ -136,7 +136,7 @@ class NoteTest < ActiveSupport::TestCase
should "create a version" do
assert_difference("NoteVersion.count", 1) do
travel(1.day) do
@note.update_attributes(:body => "fafafa")
@note.update(body: "fafafa")
end
end
assert_equal(2, @note.versions.count)
@@ -153,7 +153,7 @@ class NoteTest < ActiveSupport::TestCase
end
should "fail" do
@note.update_attributes(:x => 500)
@note.update(x: 500)
assert_equal(["Post is note locked"], @note.errors.full_messages)
end
end
@@ -172,7 +172,7 @@ class NoteTest < ActiveSupport::TestCase
@vandal = FactoryBot.create(:user)
@note = FactoryBot.create(:note, :x => 5, :y => 5)
CurrentUser.scoped(@vandal, "127.0.0.1") do
@note.update_attributes(:x => 10, :y => 10)
@note.update(x: 10, y: 10)
end
end