fix tests

This commit is contained in:
r888888888
2016-05-26 13:17:18 -07:00
parent 30415d9e1e
commit 110569708e
6 changed files with 14 additions and 19 deletions

View File

@@ -42,9 +42,7 @@ class BulkUpdateRequestTest < ActiveSupport::TestCase
should "handle errors gracefully" do
@req.stubs(:update_forum_topic_for_approve).raises(RuntimeError.new("blah"))
assert_difference("Dmail.count", 1) do
CurrentUser.scoped(@admin, "127.0.0.1") do
@req.approve!
end
@req.approve!(@admin.id)
end
assert_match(/Exception: RuntimeError/, Dmail.last.body)
assert_match(/Message: blah/, Dmail.last.body)
@@ -56,9 +54,7 @@ class BulkUpdateRequestTest < ActiveSupport::TestCase
should "update the topic when processed" do
assert_difference("ForumPost.count") do
CurrentUser.scoped(@admin, "127.0.0.1") do
@req.approve!
end
@req.approve!(@admin.id)
end
end

View File

@@ -155,15 +155,15 @@ class DTextTest < ActiveSupport::TestCase
end
def test_inline_tags
assert_equal('<p><a href="/posts?tags=tag">tag</a></p>', p("{{tag}}"))
assert_equal('<p><a rel="nofollow" href="/posts?tags=tag">tag</a></p>', p("{{tag}}"))
end
def test_inline_tags_conjunction
assert_equal('<p><a href="/posts?tags=tag1+tag2">tag1 tag2</a></p>', p("{{tag1 tag2}}"))
assert_equal('<p><a rel="nofollow" href="/posts?tags=tag1+tag2">tag1 tag2</a></p>', p("{{tag1 tag2}}"))
end
def test_inline_tags_special_entities
assert_equal('<p><a href="/posts?tags=%3C3">&lt;3</a></p>', p("{{<3}}"))
assert_equal('<p><a rel="nofollow" href="/posts?tags=%3C3">&lt;3</a></p>', p("{{<3}}"))
end
def test_extra_newlines

View File

@@ -191,28 +191,24 @@ class PostTest < ActiveSupport::TestCase
context "a parent" do
should "not reassign favorites to the parent by default" do
p1 = FactoryGirl.create(:post)
c1 = FactoryGirl.create(:post, :parent_id => p1.id, :score => 1)
c1 = FactoryGirl.create(:post, :parent_id => p1.id)
user = FactoryGirl.create(:gold_user)
c1.add_favorite!(user)
c1.delete!
p1.reload
assert(Favorite.exists?(:post_id => c1.id, :user_id => user.id))
assert(!Favorite.exists?(:post_id => p1.id, :user_id => user.id))
assert_equal(2, c1.score)
assert_equal(0, p1.score)
end
should "reassign favorites to the parent if specified" do
p1 = FactoryGirl.create(:post)
c1 = FactoryGirl.create(:post, :parent_id => p1.id, :score => 1)
c1 = FactoryGirl.create(:post, :parent_id => p1.id)
user = FactoryGirl.create(:gold_user)
c1.add_favorite!(user)
c1.delete!(:move_favorites => true)
p1.reload
assert(!Favorite.exists?(:post_id => c1.id, :user_id => user.id), "Child should not still have favorites")
assert(Favorite.exists?(:post_id => p1.id, :user_id => user.id), "Parent should have favorites")
assert_equal(1, c1.score)
assert_equal(1, p1.score)
end
should "not update the parent's has_children flag" do