From 115521906c6b4a4109cb606df08721363cd2c0d3 Mon Sep 17 00:00:00 2001 From: evazion Date: Thu, 13 Oct 2022 21:08:47 -0500 Subject: [PATCH] tumblr: fix failure to upload new Tumblr URLs containing the post title. Fix failure to upload Tumblr URLs of this form: * https://www.tumblr.com/munespice/683613396085719040/saur-family --- app/logical/source/url/tumblr.rb | 5 +++-- test/unit/sources/tumblr_test.rb | 10 ++++++++++ 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/app/logical/source/url/tumblr.rb b/app/logical/source/url/tumblr.rb index fb04c646b..3fe62ef06 100644 --- a/app/logical/source/url/tumblr.rb +++ b/app/logical/source/url/tumblr.rb @@ -48,8 +48,9 @@ class Source::URL::Tumblr < Source::URL @blog_name = subdomain unless subdomain == "www" @work_id = work_id - # https://tumblr.com/munespice/683613396085719040, new dashboard links - in ("tumblr.com" | "www.tumblr.com"), blog_name, /^\d+$/ => work_id + # https://tumblr.com/munespice/683613396085719040 # new dashboard links + # https://www.tumblr.com/yamujiburo/682910938493599744/will-tumblr-let-me-keep-this-up + in ("tumblr.com" | "www.tumblr.com"), blog_name, /^\d+$/ => work_id, *rest @blog_name = blog_name @work_id = work_id diff --git a/test/unit/sources/tumblr_test.rb b/test/unit/sources/tumblr_test.rb index 80f89bd99..47b5ca63f 100644 --- a/test/unit/sources/tumblr_test.rb +++ b/test/unit/sources/tumblr_test.rb @@ -194,6 +194,16 @@ module Sources ) end + context "A www.tumblr.com/$blog_name/$work_id/$slug URL" do + strategy_should_work( + "https://www.tumblr.com/munespice/683613396085719040/saur-family", + image_urls: ["https://64.media.tumblr.com/fd6b4692f6e902af861fbc242736ae61/010fd31ffbc70e84-a8/s21000x21000/e0587516e05bae4cec244921f220b45bed08335c.jpg"], + artist_name: "munespice", + page_url: "https://munespice.tumblr.com/post/683613396085719040", + profile_url: "https://munespice.tumblr.com" + ) + end + context "A tumblr image url for which the extractable post url is a custom domain" do strategy_should_work( "https://64.media.tumblr.com/591b370b9deb7c6ef33d8c18dc2c8db5/tumblr_ph5huubDdz1w0f6yio1_1280.jpg",