From 1341dbb262d31c9a06b1ba9e60155fbd6f563c48 Mon Sep 17 00:00:00 2001 From: evazion Date: Fri, 27 Sep 2019 21:09:27 -0500 Subject: [PATCH] Remove post changes report. This was a mod-only report that used Google BigQuery to search post versions by tag. 2b4ee0ee8 allows all users to search post versions by tag, so this report is no longer necessary. --- app/controllers/reports_controller.rb | 9 +---- app/logical/reports/post_versions.rb | 39 ------------------- app/views/reports/post_versions.html.erb | 21 ---------- .../reports/post_versions_create.html.erb | 14 ------- test/functional/reports_controller_test.rb | 7 ---- 5 files changed, 1 insertion(+), 89 deletions(-) delete mode 100644 app/logical/reports/post_versions.rb delete mode 100644 app/views/reports/post_versions.html.erb delete mode 100644 app/views/reports/post_versions_create.html.erb diff --git a/app/controllers/reports_controller.rb b/app/controllers/reports_controller.rb index f856a26e9..e1695c805 100644 --- a/app/controllers/reports_controller.rb +++ b/app/controllers/reports_controller.rb @@ -1,19 +1,12 @@ class ReportsController < ApplicationController before_action :member_only, :except => [:upload_tags] - before_action :moderator_only, :only => [:post_versions, :post_versions_create, :down_voting_post_report, :down_voting_post_report_create] + before_action :moderator_only, :only => [:down_voting_post_report, :down_voting_post_report_create] respond_to :html, :xml, :json, only: [:upload_tags] def uploads @report = Reports::Uploads.new(params[:min_date], params[:max_date], params[:queries]) end - def post_versions - end - - def post_versions_create - @report = Reports::PostVersions.new(params[:tag], params[:type]) - end - def upload_tags @user = User.find(params[:user_id]) @upload_reports = Reports::UploadTags.includes(versions: { post: :versions }).for_user(params[:user_id]).order("id desc").paginate(params[:page], :limit => params[:limit]) diff --git a/app/logical/reports/post_versions.rb b/app/logical/reports/post_versions.rb deleted file mode 100644 index 5e58c66a0..000000000 --- a/app/logical/reports/post_versions.rb +++ /dev/null @@ -1,39 +0,0 @@ -module Reports - class PostVersions - attr_reader :tag, :query - - def initialize(tag, query_type) - @tag = tag - - if query_type == "added" - @query = GoogleBigQuery::PostVersion.new.find_added(tag) - else - @query = GoogleBigQuery::PostVersion.new.find_removed(tag) - end - end - - def mock_version(row) - PostArchive.new.tap do |x| - x.id = row["f"][0]["v"] - x.post_id = row["f"][1]["v"] - x.updated_at = Time.at(row["f"][2]["v"].to_f) - x.updater_id = row["f"][3]["v"] - x.updater_ip_addr = row["f"][4]["v"] - x.tags = row["f"][5]["v"] - # x.added_tags = row["f"][6]["v"] - # x.removed_tags = row["f"][7]["v"] - x.parent_id = row["f"][8]["v"] - x.rating = row["f"][9]["v"] - x.source = row["f"][10]["v"] - end - end - - def post_versions - if query["rows"].present? - query["rows"].map {|x| mock_version(x)} - else - [] - end - end - end -end diff --git a/app/views/reports/post_versions.html.erb b/app/views/reports/post_versions.html.erb deleted file mode 100644 index 6efb00cd8..000000000 --- a/app/views/reports/post_versions.html.erb +++ /dev/null @@ -1,21 +0,0 @@ -
-
-

Post Changes Report

- -

You can search all post changes to find when and where a tag was added or removed. Only the 1,000 most recent changes will be returned.

- - <%= form_tag(reports_post_versions_create_path, :method => :post, :class => "simple_form") do %> -
- - <%= text_field_tag "tag" %> - <%= select_tag "type", options_for_select(%w(added removed)) %> -
- <%= submit_tag "Submit" %> - <% end %> - -
-
- -<% content_for(:page_title) do %> - Post Changes Report - <%= Danbooru.config.app_name %> -<% end %> diff --git a/app/views/reports/post_versions_create.html.erb b/app/views/reports/post_versions_create.html.erb deleted file mode 100644 index 23e4cfe5c..000000000 --- a/app/views/reports/post_versions_create.html.erb +++ /dev/null @@ -1,14 +0,0 @@ -
-
-

Post Changes Report

- -

Only the 1,000 most recent changes are displayed.

- - <%= render "post_versions/listing", :post_versions => @report.post_versions %> - -
-
- -<% content_for(:page_title) do %> - Post Changes Report - <%= Danbooru.config.app_name %> -<% end %> diff --git a/test/functional/reports_controller_test.rb b/test/functional/reports_controller_test.rb index 0cadd3c05..58f4df9c2 100644 --- a/test/functional/reports_controller_test.rb +++ b/test/functional/reports_controller_test.rb @@ -17,13 +17,6 @@ class ReportsControllerTest < ActionDispatch::IntegrationTest end end - context "post_versions action" do - should "render" do - get_auth reports_post_versions_path, @mod - assert_response :success - end - end - context "upload_tags action" do should "render" do get reports_upload_tags_path(user_id: @users.first)