From 1484f8852c16297967dee7b5e9d35eb70a6a2598 Mon Sep 17 00:00:00 2001
From: evazion <noizave@gmail.com>
Date: Sun, 13 Dec 2020 00:45:22 -0600
Subject: [PATCH] posts: remove "repopulated 1 old tag" message.

Remove the "Repopulated 1 old tag" message. Show "Created 1 new tag"
instead. The distinction between creating a brand new tag and
repopulating an empty tag doesn't matter.
---
 app/models/post.rb | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/app/models/post.rb b/app/models/post.rb
index 8a33ac746..5117102f2 100644
--- a/app/models/post.rb
+++ b/app/models/post.rb
@@ -1377,9 +1377,7 @@ class Post < ApplicationRecord
 
     def added_tags_are_valid
       new_tags = added_tags.select(&:empty?)
-      new_general_tags = new_tags.select(&:general?)
-      new_artist_tags = new_tags.select(&:artist?)
-      repopulated_tags = new_tags.select { |t| !t.general? && !t.meta? && (t.created_at < 1.hour.ago) }
+      new_artist_tags, new_general_tags = new_tags.partition(&:artist?)
 
       if new_general_tags.present?
         n = new_general_tags.size
@@ -1387,12 +1385,6 @@ class Post < ApplicationRecord
         self.warnings[:base] << "Created #{n} new #{(n == 1) ? "tag" : "tags"}: #{tag_wiki_links.join(", ")}"
       end
 
-      if repopulated_tags.present?
-        n = repopulated_tags.size
-        tag_wiki_links = repopulated_tags.map { |tag| "[[#{tag.name}]]" }
-        self.warnings[:base] << "Repopulated #{n} old #{(n == 1) ? "tag" : "tags"}: #{tag_wiki_links.join(", ")}"
-      end
-
       new_artist_tags.each do |tag|
         if tag.artist.blank?
           self.warnings[:base] << "Artist [[#{tag.name}]] requires an artist entry. \"Create new artist entry\":[/artists/new?artist%5Bname%5D=#{CGI.escape(tag.name)}]"