Inherit errors from StandardError instead of Exception.

.rubocop.yml

@@ -37,6 +37,9 @@ Layout/SpaceInsideBlockBraces:
 Layout/SpaceInsideHashLiteralBraces:
   Enabled: false
 
+Lint/InheritException:
+  EnforcedStyle: standard_error
+
 Naming/MethodParameterName:
   Enabled: false
 

app/controllers/maintenance/user/email_notifications_controller.rb

@@ -1,7 +1,7 @@
 module Maintenance
   module User
     class EmailNotificationsController < ApplicationController
-      class VerificationError < Exception; end
+      class VerificationError < StandardError; end
 
       before_action :validate_sig, :only => [:destroy]
       rescue_from VerificationError, :with => :render_403

app/jobs/tag_batch_change_job.rb

@@ -1,5 +1,5 @@
 class TagBatchChangeJob < ApplicationJob
-  class Error < Exception; end
+  class Error < StandardError; end
 
   queue_as :bulk_update
 

app/logical/downloads/file.rb

@@ -3,7 +3,7 @@ require 'resolv'
 module Downloads
   class File
     include ActiveModel::Validations
-    class Error < Exception; end
+    class Error < StandardError; end
 
     RETRIABLE_ERRORS = [Errno::ECONNRESET, Errno::ETIMEDOUT, Errno::EIO, Errno::EHOSTUNREACH, Errno::ECONNREFUSED, Timeout::Error, IOError]
 

app/logical/pagination_extension.rb

@@ -1,5 +1,5 @@
 module PaginationExtension
-  class PaginationError < Exception; end
+  class PaginationError < StandardError; end
 
   attr_accessor :current_page, :records_per_page, :paginator_count, :paginator_mode
 

app/logical/pawoo_api_client.rb

@@ -6,7 +6,7 @@ class PawooApiClient
   STATUS1 = %r!\Ahttps?://pawoo\.net/web/statuses/(\d+)!
   STATUS2 = %r!\Ahttps?://pawoo\.net/@.+?/([^/]+)!
 
-  class MissingConfigurationError < Exception; end
+  class MissingConfigurationError < StandardError; end
 
   class Account
     attr_reader :json

app/logical/pixiv_api_client.rb

@@ -23,7 +23,7 @@ class PixivApiClient
     VistaPro Sculptris Comi\ Po! modo DAZ\ Studio 3D-Coat
   ]
 
-  class Error < Exception; end
+  class Error < StandardError; end
   class BadIDError < Error; end
 
   class WorkResponse

app/logical/post_sets/search_error.rb

@@ -1,4 +1,4 @@
 module PostSets
-  class SearchError < Exception
+  class SearchError < StandardError
   end
 end

app/logical/post_sets/wiki_page.rb

@@ -1,5 +1,5 @@
 module PostSets
-  class SearchError < Exception
+  class SearchError < StandardError
   end
 
   class WikiPage < PostSets::Post

app/logical/session_loader.rb

@@ -1,5 +1,5 @@
 class SessionLoader
-  class AuthenticationFailure < Exception; end
+  class AuthenticationFailure < StandardError; end
 
   attr_reader :session, :cookies, :request, :params
 

app/logical/upload_service/replacer.rb

@@ -1,7 +1,7 @@
 class UploadService
   class Replacer
     extend Memoist
-    class Error < Exception; end
+    class Error < StandardError; end
 
     attr_reader :post, :replacement
 

app/logical/user_deletion.rb

@@ -1,5 +1,5 @@
 class UserDeletion
-  class ValidationError < Exception; end
+  class ValidationError < StandardError; end
 
   attr_reader :user, :password
 

app/models/artist.rb

@@ -1,6 +1,6 @@
 class Artist < ApplicationRecord
   extend Memoist
-  class RevertError < Exception; end
+  class RevertError < StandardError; end
 
   attr_accessor :url_string_changed
   array_attribute :other_names

app/models/artist_commentary.rb

@@ -1,5 +1,5 @@
 class ArtistCommentary < ApplicationRecord
-  class RevertError < Exception; end
+  class RevertError < StandardError; end
 
   attr_accessor :remove_commentary_tag, :remove_commentary_request_tag, :remove_commentary_check_tag, :remove_partial_commentary_tag
   attr_accessor :add_commentary_tag, :add_commentary_request_tag, :add_commentary_check_tag, :add_partial_commentary_tag

app/models/comment_vote.rb

@@ -1,5 +1,5 @@
 class CommentVote < ApplicationRecord
-  class Error < Exception; end
+  class Error < StandardError; end
 
   belongs_to :comment
   belongs_to :user

app/models/favorite.rb

@@ -1,5 +1,5 @@
 class Favorite < ApplicationRecord
-  class Error < Exception; end
+  class Error < StandardError; end
 
   belongs_to :post
   belongs_to :user

app/models/note.rb

@@ -1,5 +1,5 @@
 class Note < ApplicationRecord
-  class RevertError < Exception; end
+  class RevertError < StandardError; end
 
   attr_accessor :html_id
   belongs_to :post

app/models/pool.rb

@@ -1,5 +1,5 @@
 class Pool < ApplicationRecord
-  class RevertError < Exception; end
+  class RevertError < StandardError; end
   POOL_ORDER_LIMIT = 1000
 
   array_attribute :post_ids, parse: /\d+/, cast: :to_i

app/models/pool_version.rb

@@ -1,5 +1,5 @@
 class PoolVersion < ApplicationRecord
-  class Error < Exception; end
+  class Error < StandardError; end
 
   belongs_to :pool
   belongs_to_updater

app/models/post.rb

@@ -1,12 +1,12 @@
 require 'danbooru/has_bit_flags'
 
 class Post < ApplicationRecord
-  class ApprovalError < Exception; end
+  class ApprovalError < StandardError; end
-  class DisapprovalError < Exception; end
+  class DisapprovalError < StandardError; end
-  class RevertError < Exception; end
+  class RevertError < StandardError; end
-  class SearchError < Exception; end
+  class SearchError < StandardError; end
-  class DeletionError < Exception; end
+  class DeletionError < StandardError; end
-  class TimeoutError < Exception; end
+  class TimeoutError < StandardError; end
 
   # Tags to copy when copying notes.
   NOTE_COPY_TAGS = %w[translated partially_translated check_translation translation_request reverse_translation]

app/models/post_appeal.rb

@@ -1,5 +1,5 @@
 class PostAppeal < ApplicationRecord
-  class Error < Exception; end
+  class Error < StandardError; end
 
   MAX_APPEALS_PER_DAY = 1
 

app/models/post_archive.rb

@@ -1,5 +1,5 @@
 class PostArchive < ApplicationRecord
-  class RevertError < Exception; end
+  class RevertError < StandardError; end
   extend Memoist
 
   belongs_to :post

app/models/post_flag.rb

@@ -1,5 +1,5 @@
 class PostFlag < ApplicationRecord
-  class Error < Exception; end
+  class Error < StandardError; end
 
   module Reasons
     UNAPPROVED = "Unapproved in three days"

app/models/post_vote.rb

@@ -1,5 +1,5 @@
 class PostVote < ApplicationRecord
-  class Error < Exception; end
+  class Error < StandardError; end
 
   belongs_to :post
   belongs_to :user

app/models/upload.rb

@@ -1,7 +1,7 @@
 require "tmpdir"
 
 class Upload < ApplicationRecord
-  class Error < Exception; end
+  class Error < StandardError; end
 
   class FileValidator < ActiveModel::Validator
     def validate(record)

app/models/user.rb

@@ -2,8 +2,8 @@ require 'digest/sha1'
 require 'danbooru/has_bit_flags'
 
 class User < ApplicationRecord
-  class Error < Exception; end
+  class Error < StandardError; end
-  class PrivilegeError < Exception; end
+  class PrivilegeError < StandardError; end
 
   module Levels
     ANONYMOUS = 0

app/models/wiki_page.rb

@@ -1,5 +1,5 @@
 class WikiPage < ApplicationRecord
-  class RevertError < Exception; end
+  class RevertError < StandardError; end
 
   META_WIKIS = ["list_of_", "tag_group:", "pool_group:", "howto:", "about:", "help:", "template:"]