jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

posts: micro-optimize allocations during thumbnail generation.

Browse Source 
Do a few micro-optimizations to reduce the number of memory allocations
during thumbnail generation.

This commit, combined with freezing string literals in a7dc05 and
67b961, reduces the number of allocations on the front page from 180,000
to 150,000, and the number of retained objects from 8,000 to 4,000.
This commit is contained in:
evazion
2021-12-15 22:48:24 -06:00
parent 3fcecd59a8
commit 163ba8e7da
4 changed files with 14 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
app/models/post.rb
View File

@@ -8,6 +8,8 @@ class Post < ApplicationRecord
NOTE_COPY_TAGS = %w[translated partially_translated check_translation translation_request reverse_translation
annotated partially_annotated check_annotation annotation_request]
RESTRICTED_TAGS = Danbooru.config.restricted_tags
self.ignored_columns = [:pool_string, :fav_string]
deletable
@@ -292,11 +294,11 @@ class Post < ApplicationRecord
module TagMethods
def tag_array
@tag_array ||= tag_string.split
tag_string.split
end
def tag_array_was
@tag_array_was ||= (tag_string_in_database.presence || tag_string_before_last_save || "").split
(tag_string_in_database.presence || tag_string_before_last_save || "").split
end
def tags
@@ -346,7 +348,6 @@ class Post < ApplicationRecord
end
def merge_old_changes
reset_tag_array_cache
@removed_tags = []
if old_tag_string
@@ -380,14 +381,8 @@ class Post < ApplicationRecord
end
end
def reset_tag_array_cache
@tag_array = nil
@tag_array_was = nil
end
def set_tag_string(string)
self.tag_string = string
reset_tag_array_cache
end
def normalize_tags
@@ -1298,7 +1293,7 @@ class Post < ApplicationRecord
end
def levelblocked?(user = CurrentUser.user)
!user.is_gold? && Danbooru.config.restricted_tags.any? { |tag| tag.in?(tag_array) }
!user.is_gold? && RESTRICTED_TAGS.any? { |tag| tag.in?(tag_array) }
end
def banblocked?(user = CurrentUser.user)
@@ -1312,7 +1307,6 @@ class Post < ApplicationRecord
def reload(options = nil)
super
reset_tag_array_cache
@pools = nil
@tag_categories = nil
@typed_tags = nil