From 181a906766dfc276f32c31e8232bf0aa0586b88d Mon Sep 17 00:00:00 2001 From: evazion Date: Sat, 5 May 2018 12:21:11 -0500 Subject: [PATCH] Fix #3695: Bookmarklet breaks on pixiv fanbox direct image links. --- app/logical/downloads/rewrite_strategies/pixiv.rb | 2 +- test/unit/downloads/pixiv_test.rb | 10 ++++++++++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/app/logical/downloads/rewrite_strategies/pixiv.rb b/app/logical/downloads/rewrite_strategies/pixiv.rb index 863258195..ec897695f 100644 --- a/app/logical/downloads/rewrite_strategies/pixiv.rb +++ b/app/logical/downloads/rewrite_strategies/pixiv.rb @@ -28,7 +28,7 @@ module Downloads end return [url, headers, data] - rescue PixivApiClient::BadIDError + rescue PixivApiClient::BadIDError, Sources::Site::NoStrategyError return [url, headers, data] end diff --git a/test/unit/downloads/pixiv_test.rb b/test/unit/downloads/pixiv_test.rb index 3441ee81b..54f4161ff 100644 --- a/test/unit/downloads/pixiv_test.rb +++ b/test/unit/downloads/pixiv_test.rb @@ -169,6 +169,16 @@ module Downloads assert_downloaded(@file_size, @file_url) end end + + context "downloading a pixiv fanbox image" do + should "work" do + @file_url = "https://fanbox.pixiv.net/images/post/31757/w/1200/0CdXtgr4al3t43gQG4NZLnpQ.jpeg" + @file_size = 200_239 + + assert_not_rewritten(@file_url) + assert_downloaded(@file_size, @file_url) + end + end end end end