jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

BURs: add size requirements for implications.

Browse Source 
Implications now have the following rules:

* The child tag must have at least 10 posts.
* The child tag must be at least 0.01% the size of the parent tag.
* The child tag can't make up more than 90% of the parent tag.
* These rules only apply to general tags.
This commit is contained in:
evazion
2020-12-03 13:58:51 -06:00
parent 4a4c198287
commit 1c9a926eac
2 changed files with 42 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
test/unit/bulk_update_request_test.rb
View File

@@ -152,6 +152,21 @@ class BulkUpdateRequestTest < ActiveSupport::TestCase
assert_equal(false, @bur.valid?)
assert_equal(["Can't create implication hatsune_miku -> vocaloid (Can't imply a character tag to a copyright tag)"], @bur.errors.full_messages)
end
should "fail for a child tag that is too small" do
@t1 = create(:tag, name: "white_shirt", post_count: 9)
@t2 = create(:tag, name: "shirt", post_count: 1000000)
create(:wiki_page, title: "white_shirt")
create(:wiki_page, title: "shirt")
@bur = build(:bulk_update_request, script: "imply white_shirt -> shirt")
assert_equal(false, @bur.valid?)
assert_equal(["Can't create implication white_shirt -> shirt ('white_shirt' must have at least 10 posts)"], @bur.errors.full_messages)
@t1.update!(post_count: 99)
assert_equal(false, @bur.valid?)
assert_equal(["Can't create implication white_shirt -> shirt ('white_shirt' must have at least 100 posts)"], @bur.errors.full_messages)
end
end
context "the remove alias command" do
@@ -342,8 +357,8 @@ class BulkUpdateRequestTest < ActiveSupport::TestCase
context "requesting an implication for a populated tag without a wiki" do
should "fail" do
create(:tag, name: "a", post_count: 1)
create(:tag, name: "b", post_count: 1)
create(:tag, name: "a", post_count: 10)
create(:tag, name: "b", post_count: 100)
@bur = build(:bulk_update_request, script: "imply a -> b")
assert_equal(false, @bur.valid?)