controllers: refactor only param includes.

Add extra includes needed by the `only` param inside `respond_with`.
This commit is contained in:
evazion
2020-02-14 20:08:42 -06:00
parent 8649ff6dbe
commit 2564e885c8
42 changed files with 153 additions and 387 deletions

View File

@@ -19,7 +19,9 @@ class UserFeedbacksController < ApplicationController
end
def index
@user_feedbacks = UserFeedback.paginated_search(params, count_pages: true).includes(model_includes(params))
@user_feedbacks = UserFeedback.paginated_search(params, count_pages: true)
@user_feedbacks = @user_feedbacks.includes(:user, :creator) if request.format.html?
respond_with(@user_feedbacks)
end
@@ -37,14 +39,6 @@ class UserFeedbacksController < ApplicationController
private
def default_includes(params)
if ["json", "xml"].include?(params[:format])
[]
else
[:user, :creator]
end
end
def check_privilege(user_feedback)
raise User::PrivilegeError unless user_feedback.editable_by?(CurrentUser.user)
end