jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

posts: fix error when viewing nonexistent post IDs.

Browse Source
This commit is contained in:
evazion
2021-04-01 18:24:26 -05:00
parent d58a0bf1e4
commit 26496bba8d
2 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/views/layouts/default.html.erb
View File

@@ -18,7 +18,7 @@
<% end %> <% end %>
<%# XXX hack to only load Ruffle on Flash posts %> <%# XXX hack to only load Ruffle on Flash posts %>
<% if controller_name == "posts" && action_name == "show" && @post.is_flash? %> <% if controller_name == "posts" && action_name == "show" && @post&.is_flash? %>
<%= javascript_pack_tag "application", "flash" %> <%= javascript_pack_tag "application", "flash" %>
<% else %> <% else %>
<%= javascript_pack_tag "application" %> <%= javascript_pack_tag "application" %>

8
test/functional/posts_controller_test.rb
View File

@@ -567,6 +567,14 @@ class PostsControllerTest < ActionDispatch::IntegrationTest
end end
end end
context "a nonexistent post id" do
should "return 404" do
get post_path(id: 9_999_999)
assert_response 404
end
end
context "with pools" do context "with pools" do
should "render the pool list" do should "render the pool list" do
as(@user) { @post.update(tag_string: "newpool:comic") } as(@user) { @post.update(tag_string: "newpool:comic") }