From 2794cd254d42ddef4366c21f94bf04b18fbd7e76 Mon Sep 17 00:00:00 2001 From: lllusion3469 <31420484+lllusion3469@users.noreply.github.com> Date: Mon, 11 May 2020 00:07:36 +0200 Subject: [PATCH] deviantart: return nil on failure instead of "" was also part of eba6440b8ba440b4007c4eab2d7840419ada5a85 --- app/logical/sources/strategies/deviant_art.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/logical/sources/strategies/deviant_art.rb b/app/logical/sources/strategies/deviant_art.rb index 30aaf91ef..d0dda62cf 100644 --- a/app/logical/sources/strategies/deviant_art.rb +++ b/app/logical/sources/strategies/deviant_art.rb @@ -106,7 +106,7 @@ module Sources elsif deviation_id.present? page_url_from_image_url else - "" + nil end end @@ -123,7 +123,7 @@ module Sources end def profile_url - return "" if artist_name.blank? + return nil if artist_name.blank? "https://www.deviantart.com/#{artist_name.downcase}" end @@ -135,7 +135,7 @@ module Sources elsif api_metadata.present? api_metadata.dig(:author, :username) else - "" + nil end end