Clean up pool version diffs

Related to #1724

app/helpers/pool_versions_helper.rb

@@ -1,14 +1,17 @@
 module PoolVersionsHelper
-  def pool_version_diff(current)
+  def pool_version_diff(pool_version)
-    prev = PoolVersion.where(["pool_id = ? and updated_at < ?", current.pool_id, current.updated_at]).order("updated_at desc").first
+    html = ""
 
-    if prev.nil?
+    html << pool_version.changes[:added_posts].map do |post_id|
-      return current.post_id_array.map {|x| '<ins><a href="/posts/' + x.to_s + '">' + x.to_s + '</a></ins>'}.join(" ").html_safe
+      '<ins><a href="/posts/' + post_id.to_s + '">' + post_id.to_s + '</a></ins>'
-    end
+    end.join(" ")
 
-    added = current.post_id_array - prev.post_id_array
+    html << " "
-    removed = prev.post_id_array - current.post_id_array
 
-    (added.map {|x| '<ins><a href="/posts/' + x.to_s + '">' + x.to_s + '</a></ins>'}.join(" ") + " " + removed.map {|x| '<del><a href="/posts/' + x.to_s + '">' + x.to_s + '</a></del>'}.join(" ")).html_safe
+    html << pool_version.changes[:removed_posts].map do |post_id|
+      '<del><a href="/posts/' + post_id.to_s + '">' + post_id.to_s + '</a></del>'
+    end.join(" ")
+
+    return html.html_safe
   end
 end

app/models/pool_version.rb

@@ -49,4 +49,23 @@ class PoolVersion < ActiveRecord::Base
   def post_id_array
     @post_id_array ||= post_ids.scan(/\d+/).map(&:to_i)
   end
+
+  def diff(version)
+    new_posts = post_id_array
+    old_posts = version.present? ? version.post_id_array : []
+
+    return {
+      :added_posts => new_posts - old_posts,
+      :removed_posts => old_posts - new_posts,
+      :unchanged_posts => new_posts & old_posts
+    }
+  end
+
+  def changes
+    @changes ||= diff(previous)
+  end
+
+  def previous
+    PoolVersion.where(["pool_id = ? and updated_at < ?", pool_id, updated_at]).order("updated_at desc").first
+  end
 end