Add show actions for note, artist, artist commentary versions.

Add these endpoints:

* /note_versions/1234
* /artist_versions/1234
* /artist_commentary_versions/1234

This is so the /ip_addresses listing can link to these endpoints.

test/functional/artist_commentary_versions_controller_test.rb

@@ -2,14 +2,11 @@ require 'test_helper'
 
 class ArtistCommentaryVersionsControllerTest < ActionDispatch::IntegrationTest
   context "The artist commentary versions controller" do
-  	setup do
-      @user = FactoryBot.create(:user)
-
-      as_user do
-        @commentary1 = FactoryBot.create(:artist_commentary)
-        @commentary2 = FactoryBot.create(:artist_commentary)
-      end
-  	end
+    setup do
+      @user = create(:user)
+      @commentary1 = as(@user) { create(:artist_commentary) }
+      @commentary2 = as(@user) { create(:artist_commentary) }
+    end
 
     context "index action" do
       should "render" do
@@ -17,5 +14,15 @@ class ArtistCommentaryVersionsControllerTest < ActionDispatch::IntegrationTest
         assert_response :success
       end
     end
+
+    context "show action" do
+      should "work" do
+        get artist_commentary_version_path(@commentary1.versions.first)
+        assert_redirected_to artist_commentary_versions_path(search: { post_id: @commentary1.post_id })
+
+        get artist_commentary_version_path(@commentary1.versions.first), as: :json
+        assert_response :success
+      end
+    end
   end
 end

test/functional/artist_versions_controller_test.rb

@@ -3,10 +3,8 @@ require 'test_helper'
 class ArtistVersionsControllerTest < ActionDispatch::IntegrationTest
   context "An artist versions controller" do
     setup do
-      @user = FactoryBot.create(:gold_user)
-      as_user do
-        @artist = create(:artist)
-      end
+      @user = create(:gold_user)
+      @artist = as(@user) { create(:artist) }
     end
 
     should "get the index page" do
@@ -18,5 +16,15 @@ class ArtistVersionsControllerTest < ActionDispatch::IntegrationTest
       get_auth artist_versions_path(search: {name: @artist.name}), @user
       assert_response :success
     end
+
+    context "show action" do
+      should "work" do
+        get artist_version_path(@artist.versions.first)
+        assert_redirected_to artist_versions_path(search: { artist_id: @artist.id })
+
+        get artist_version_path(@artist.versions.first), as: :json
+        assert_response :success
+      end
+    end
   end
 end

test/functional/note_versions_controller_test.rb

@@ -4,24 +4,14 @@ class NoteVersionsControllerTest < ActionDispatch::IntegrationTest
   context "The note versions controller" do
     setup do
       @user = create(:user)
+      @user_2 = create(:user)
+
+      as(@user) { @note = create(:note) }
+      as(@user_2) { @note.update(body: "1 2") }
+      as(@user) { @note.update(body: "1 2 3") }
     end
 
     context "index action" do
-      setup do
-        as_user do
-          @note = create(:note)
-        end
-        @user_2 = create(:user)
-
-        CurrentUser.scoped(@user_2, "1.2.3.4") do
-          @note.update(body: "1 2")
-        end
-
-        CurrentUser.scoped(@user, "1.2.3.4") do
-          @note.update(body: "1 2 3")
-        end
-      end
-
       should "list all versions" do
         get note_versions_path
         assert_response :success
@@ -32,5 +22,15 @@ class NoteVersionsControllerTest < ActionDispatch::IntegrationTest
         assert_response :success
       end
     end
+
+    context "show action" do
+      should "work" do
+        get note_version_path(@note.versions.first)
+        assert_redirected_to note_versions_path(search: { note_id: @note.id })
+
+        get note_version_path(@note.versions.first), as: :json
+        assert_response :success
+      end
+    end
   end
 end