BulkUpdateRequest#approve!: don't swallow exceptions.

Rescue `AliasAndImplicationImporter::Error` instead of `Exception`.
This commit is contained in:
evazion
2018-02-24 14:37:02 -06:00
parent 3fefb73e90
commit 2b8767d7f4
3 changed files with 12 additions and 11 deletions

View File

@@ -96,7 +96,7 @@ class BulkUpdateRequest < ApplicationRecord
forum_updater.update("The #{bulk_update_request_link} (forum ##{forum_post.id}) has been approved by @#{approver.name}.", "APPROVED")
end
rescue Exception => x
rescue AliasAndImplicationImporter::Error => x
self.approver = approver
CurrentUser.scoped(approver) do
forum_updater.update("The #{bulk_update_request_link} (forum ##{forum_post.id}) has failed: #{x.to_s}", "FAILED")