jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

sources: remove image_url method from base strategy.

Browse Source 
Remove the `image_url` method from source strategies. This method would
return only the first image if a source had multiple images. The
`image_urls` method should be used instead. Tests were the main place
that still used `image_url` instead of `image_urls`.

Also make post replacements return an error if replacing with a source
that contains multiple images, instead of just blindly replacing the
post with the first image in the source.
This commit is contained in:
evazion
2022-03-11 01:55:29 -06:00
parent 4701027f45
commit 2f61486ac6
29 changed files with 164 additions and 159 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
test/unit/sources/foundation_test.rb
View File

@@ -31,14 +31,14 @@ module Sources
end
should "get the image url" do
assert_equal(@image_url, @image1.image_url)
assert_equal(@image_url, @image2.image_url)
assert_equal([@image_url], @image1.image_urls)
assert_equal([@image_url], @image2.image_urls)
end
should "download an image" do
assert_downloaded(13_908_349, @image1.image_url)
assert_downloaded(13_908_349, @image2.image_url)
assert_downloaded(13_391_766, @image3.image_url)
assert_downloaded(13_908_349, @image1.image_urls.sole)
assert_downloaded(13_908_349, @image2.image_urls.sole)
assert_downloaded(13_391_766, @image3.image_urls.sole)
end
should "find the correct artist" do
@@ -104,8 +104,8 @@ module Sources
image = "https://f8n-ipfs-production.imgix.net/QmVnpe39qodMjTe8v3fijPfB1tjwhT8hgobtgLPtsangqc/nft.png"
assert_nothing_raised { case1.to_h }
assert_nothing_raised { case2.to_h }
assert_equal(image, case1.image_url)
assert_equal(image, case2.image_url)
assert_equal([image], case1.image_urls)
assert_equal([image], case2.image_urls)
end
end