jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

searchable: standardize the <field>_matches operator for text fields.

Browse Source 
Standardize it so that all fields of type `text` are searchable with
`search[<field>_matches]`.

Before, the `<field>_matches` param was handled manually and some fields
were left out or handled inconsistently. Now it applies to all columns
of type `text`.

This does a full-text search on the field, so for example, searching
`/artist_commentaries?search[translated_description_matches]=smiling`
will match translated commentaries containing either the word "smiling",
"smiles", "smiled", or "smile".

Note that this only applies to columns defined as type `text`, not to
columns defined as `character varying`. The difference is that `text` is
used for fields containing free-form natural language, such as comments,
notes, forum posts, wiki pages, pool descriptions, etc, while `character
varying` is used for short strings not containing free-form language,
such as tag names, wiki page titles, urls, status fields, etc.

API changes:

* Add the `search[original_title_matches]`, `search[original_description_matches]`,
  `search[translated_title_matches]`, `search[translated_description_matches]` params
  to /artist_commentaries and /artist_commentary_versions.
* Remove the `search[name_matches]` and `search[group_name_matches]` params from /artist_versions.
* Remove the `search[title_matches]` param from /wiki_page_versions.
* Change the `search[name_matches]` param on /pools, /favorite_groups, and /pool_versions
  to do a full-text search instead of a substring match.
This commit is contained in:
evazion
2022-09-21 19:32:25 -05:00
parent a6e0872ce4
commit 3114ef3daf
21 changed files with 18 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test/functional/wiki_page_versions_controller_test.rb
View File

@@ -21,7 +21,7 @@ class WikiPageVersionsControllerTest < ActionDispatch::IntegrationTest
end
should respond_to_search({}).with { @versions.reverse }
should respond_to_search(title_matches: "supreme").with { [@versions[2], @versions[1]] }
should respond_to_search(title_like: "supreme").with { [@versions[2], @versions[1]] }
should respond_to_search(body_matches: "blah").with { [@versions[2], @versions[1]] }
should respond_to_search(other_names_include_any: "not_this").with { [@versions[2], @versions[1]] }