Fix #4853: Users should not be able to search by disapprover

This commit is contained in:
evazion
2021-08-31 21:09:14 -05:00
parent 38c9559fe8
commit 374298a743
2 changed files with 36 additions and 2 deletions

View File

@@ -56,7 +56,7 @@ class PostDisapprovalsControllerTest < ActionDispatch::IntegrationTest
context "using includes" do
should respond_to_search(post_tags_match: "touhou").with { @post_disapproval }
should respond_to_search(post: {uploader_name: "marisa"}).with { @post_disapproval }
should respond_to_search(user_name: "eiki").with { @user_disapproval }
should respond_to_search(user_name: "eiki").with { [] }
end
should "allow mods to see disapprover names" do
@@ -70,6 +70,20 @@ class PostDisapprovalsControllerTest < ActionDispatch::IntegrationTest
assert_response :success
assert_select "tr#post-disapproval-#{@post_disapproval.id} .created-column a.user-post-approver", false
end
context "when a non-mod searches by disapprover name" do
should respond_to_search(user_name: "eiki").with { [] }
end
context "when a mod searches by disapprover name" do
setup { CurrentUser.user = create(:mod_user) }
should respond_to_search(user_name: "eiki").with { @user_disapproval }
end
context "when a disapprover searches by their own name" do
setup { CurrentUser.user = @approver }
should respond_to_search(user_name: "eiki").with { @user_disapproval }
end
end
end
end