Fix #4053: Add disapproval index improvements.

Add search form to /moderator/post/disapprovals.

test/functional/moderator/post/disapprovals_controller_test.rb

@@ -9,6 +9,8 @@ module Moderator
           as_user do
             @post = create(:post, :is_pending => true)
           end
+
+          CurrentUser.user = @admin
         end
 
         context "create action" do
@@ -28,6 +30,15 @@ module Moderator
             end
           end
         end
+
+        context "index action" do
+          should "render" do
+            disapproval = FactoryBot.create(:post_disapproval, post: @post)
+            get_auth moderator_post_disapprovals_path, @admin
+
+            assert_response :success
+          end
+        end
       end
     end
   end

test/unit/post_disapproval_test.rb

@@ -3,7 +3,7 @@ require 'test_helper'
 class PostDisapprovalTest < ActiveSupport::TestCase
   context "In all cases" do
     setup do
-      @alice = FactoryBot.create(:moderator_user)
+      @alice = FactoryBot.create(:moderator_user, name: "alice")
       CurrentUser.user = @alice
       CurrentUser.ip_addr = "127.0.0.1"
     end
@@ -90,6 +90,17 @@ class PostDisapprovalTest < ActiveSupport::TestCase
           assert(@uploaders[1].dmails.exists?(from: bot, to: @uploaders[1]))
         end
       end
+
+      context "#search" do
+        should "work" do
+          disapproval1 = FactoryBot.create(:post_disapproval, user: @alice, post: @post_1, reason: "breaks_rules")
+          disapproval2 = FactoryBot.create(:post_disapproval, user: @alice, post: @post_2, reason: "poor_quality", message: "bad anatomy")
+
+          assert_equal([disapproval1.id], PostDisapproval.search(reason: "breaks_rules").pluck(:id))
+          assert_equal([disapproval2.id], PostDisapproval.search(message: "bad anatomy").pluck(:id))
+          assert_equal([disapproval2.id, disapproval1.id], PostDisapproval.search(creator_name: "alice").pluck(:id))
+        end
+      end
     end
   end
 end