user name changes: remove unused reason, status fields.

Remove all infrastructure around approving or rejecting user name
changes. Name changes haven't been moderated for several years.

* Remove status, approver_id, change_reason, and rejection_reason fields.
* Remove approve and reject controller actions.

app/controllers/user_name_change_requests_controller.rb

@@ -1,47 +1,29 @@
 class UserNameChangeRequestsController < ApplicationController
   before_action :member_only, :only => [:index, :show]
   before_action :gold_only, :only => [:new, :create]
-  before_action :admin_only, :only => [:approve, :reject]
   respond_to :html, :json, :xml
 
   def new
     @change_request = UserNameChangeRequest.new(change_request_params)
     respond_with(@change_request)
   end
-  
+
   def create
-    @change_request = UserNameChangeRequest.create(change_request_params)
-    
-    if @change_request.errors.any?
-      render :action => "new"
-    else
-      @change_request.approve! 
-      redirect_to user_name_change_request_path(@change_request), :notice => "Your name has been changed"
-    end
+    @change_request = UserNameChangeRequest.create_with(user: CurrentUser.user, original_name: CurrentUser.name).create(change_request_params)
+    flash[:notice] = "Your name has been changed"
+    respond_with(@change_request, location: profile_path)
   end
-  
+
   def show
     @change_request = UserNameChangeRequest.find(params[:id])
     check_privileges!(@change_request)
     respond_with(@change_request)
   end
-  
+
   def index
     @change_requests = UserNameChangeRequest.visible.order("id desc").paginate(params[:page], :limit => params[:limit])
     respond_with(@change_requests)
   end
-  
-  def approve
-    @change_request = UserNameChangeRequest.find(params[:id])
-    @change_request.approve!
-    redirect_to user_name_change_request_path(@change_request), :notice => "Name change request approved"
-  end
-  
-  def reject
-    @change_request = UserNameChangeRequest.find(params[:id])
-    @change_request.reject!(params[:reason])
-    redirect_to user_name_change_request_path(@change_request), :notice => "Name change request rejected"
-  end
 
   private
 
@@ -51,6 +33,6 @@ class UserNameChangeRequestsController < ApplicationController
   end
 
   def change_request_params
-    params.fetch(:user_name_change_request, {}).permit(%i[desired_name change_reason])
+    params.fetch(:user_name_change_request, {}).permit(%i[desired_name])
   end
 end