user name changes: remove unused reason, status fields.

Remove all infrastructure around approving or rejecting user name
changes. Name changes haven't been moderated for several years.

* Remove status, approver_id, change_reason, and rejection_reason fields.
* Remove approve and reject controller actions.

app/models/user_name_change_request.rb

@@ -1,75 +1,34 @@
 class UserNameChangeRequest < ApplicationRecord
-  after_initialize :initialize_attributes, if: :new_record?
-  validates_presence_of :original_name, :desired_name
-  validates_inclusion_of :status, :in => %w(pending approved rejected)
   belongs_to :user
-  belongs_to :approver, :class_name => "User", optional: true
-  validate :not_limited, :on => :create
+  belongs_to :approver, class_name: "User", optional: true
+
+  validate :not_limited, on: :create
   validates :desired_name, user_name: true
+  validates_presence_of :original_name, :desired_name
 
-  def initialize_attributes
-    self.user_id ||= CurrentUser.user.id
-    self.original_name ||= CurrentUser.user.name
-  end
-  
-  def self.pending
-    where(:status => "pending")
-  end
-
-  def self.approved
-    where(:status => "approved")
-  end
+  after_create :approve!
 
   def self.visible(viewer = CurrentUser.user)
     if viewer.is_admin?
       all
     elsif viewer.is_member?
-      joins(:user).merge(User.undeleted).where("user_name_change_requests.status = 'approved' OR user_name_change_requests.user_id = ?", viewer.id)
+      joins(:user).merge(User.undeleted).where("user_name_change_requests.user_id = ?", viewer.id)
     else
       none
     end
   end
-  
-  def rejected?
-    status == "rejected"
-  end
-  
-  def approved?
-    status == "approved"
-  end
 
-  def pending?
-    status == "pending"
-  end
-  
-  def feedback
-    user.feedback.order("id desc")
-  end
-  
   def approve!
-    update(status: "approved", approver_id: CurrentUser.user.id)
     user.update_attribute(:name, desired_name)
     body = "Your name change request has been approved. Be sure to log in with your new user name."
     Dmail.create_automated(:title => "Name change request approved", :body => body, :to_id => user_id)
     UserFeedback.create(:user_id => user_id, :category => "neutral", :body => "Name changed from #{original_name} to #{desired_name}")
     ModAction.log("Name changed from #{original_name} to #{desired_name}",:user_name_change)
   end
-  
-  def reject!(reason)
-    update(status: "rejected", rejection_reason: reason)
-    body = "Your name change request has been rejected for the following reason: #{rejection_reason}"
-    Dmail.create_automated(:title => "Name change request rejected", :body => body, :to_id => user_id)
-  end
-  
+
   def not_limited
-    if UserNameChangeRequest.where("user_id = ? and created_at >= ?", CurrentUser.user.id, 1.week.ago).exists?
-      errors.add(:base, "You can only submit one name change request per week")
+    if UserNameChangeRequest.unscoped.where(user: user).where("created_at >= ?", 1.week.ago).exists?
+      errors[:base] << "You can only submit one name change request per week"
     end
   end
-
-  def api_attributes
-    attributes = super
-    attributes -= [:change_reason, :rejection_reason] unless CurrentUser.is_admin? || user == CurrentUser.user
-    attributes
-  end
 end