pundit: convert saved searches to pundit.

This commit is contained in:
evazion
2020-03-20 00:12:05 -05:00
parent 415d9591c5
commit 3bb3c0b990
4 changed files with 60 additions and 34 deletions

View File

@@ -4,9 +4,7 @@ class SavedSearchesControllerTest < ActionDispatch::IntegrationTest
context "The saved searches controller" do
setup do
@user = create(:user)
as_user do
@saved_search = create(:saved_search, user: @user)
end
@saved_search = create(:saved_search, user: @user)
end
context "index action" do
@@ -17,24 +15,29 @@ class SavedSearchesControllerTest < ActionDispatch::IntegrationTest
end
end
context "labels action" do
should "render" do
get_auth labels_saved_searches_path, @user, as: :json
assert_response :success
end
end
context "create action" do
should "render" do
post_auth saved_searches_path, @user, params: { saved_search: { query: "bkub", label_string: "artist" }}
assert_response :redirect
assert_redirected_to SavedSearch.last
end
should "disable labels when the disable_labels param is given" do
post_auth saved_searches_path, @user, params: { saved_search: { query: "bkub", disable_labels: "1" }}
assert_redirected_to SavedSearch.last
assert_equal(true, @user.reload.disable_categorized_saved_searches)
end
end
context "edit action" do
should "render" do
as_user do
@saved_search = create(:saved_search, user: @user)
end
@saved_search = create(:saved_search, user: @user)
get_auth edit_saved_search_path(@saved_search), @user, params: { id: @saved_search.id }
assert_response :success
end
@@ -42,24 +45,33 @@ class SavedSearchesControllerTest < ActionDispatch::IntegrationTest
context "update action" do
should "render" do
as_user do
@saved_search = create(:saved_search, user: @user)
end
params = { id: @saved_search.id, saved_search: { label_string: "foo" } }
put_auth saved_search_path(@saved_search), @user, params: params
put_auth saved_search_path(@saved_search), @user, params: { saved_search: { label_string: "foo" }}
assert_redirected_to saved_searches_path
assert_equal(["foo"], @saved_search.reload.labels)
end
should "not allow users to update saved searches belonging to other users" do
put_auth saved_search_path(@saved_search), create(:user), params: { saved_search: { label_string: "foo" }}
assert_response 403
assert_not_equal(["foo"], @saved_search.reload.labels)
end
end
context "destroy action" do
should "render" do
as_user do
@saved_search = create(:saved_search, user: @user)
@saved_search = create(:saved_search, user: @user)
assert_difference("SavedSearch.count", -1) do
delete_auth saved_search_path(@saved_search), @user
assert_redirected_to saved_searches_path
end
end
delete_auth saved_search_path(@saved_search), @user
assert_redirected_to saved_searches_path
should "not allow users to destroy saved searches belonging to other users" do
@saved_search = create(:saved_search, user: @user)
assert_difference("SavedSearch.count", 0) do
delete_auth saved_search_path(@saved_search), create(:user)
assert_response 403
end
end
end
end