diff --git a/app/models/mod_action.rb b/app/models/mod_action.rb index 393a75b2b..cbec8de4d 100644 --- a/app/models/mod_action.rb +++ b/app/models/mod_action.rb @@ -20,7 +20,7 @@ class ModAction < ApplicationRecord user_level_change: 7, user_approval_privilege: 8, user_upload_privilege: 9, - user_account_upgrade: 19, + user_account_upgrade: 19, # XXX unused user_feedback_update: 21, user_feedback_delete: 22, post_delete: 42, diff --git a/app/models/user_upgrade.rb b/app/models/user_upgrade.rb index c5a369293..2eaead91b 100644 --- a/app/models/user_upgrade.rb +++ b/app/models/user_upgrade.rb @@ -108,7 +108,6 @@ class UserUpgrade < ApplicationRecord if payment_status == "paid" upgrade_recipient! - create_mod_action! dmail_recipient! dmail_purchaser! update!(status: :complete) @@ -122,10 +121,6 @@ class UserUpgrade < ApplicationRecord recipient.update!(level: level) end - def create_mod_action! - ModAction.log(%{"#{recipient.name}":#{Routes.user_path(recipient)} level changed #{User.level_string(recipient.level_before_last_save)} -> #{recipient.level_string}}, :user_account_upgrade, purchaser) - end - def dmail_recipient! if is_gift? body = "Congratulations, your account has been upgraded to #{level_string} by <@#{purchaser.name}>. Enjoy!" diff --git a/test/unit/user_upgrade_test.rb b/test/unit/user_upgrade_test.rb index 124cebf22..99d9ccf96 100644 --- a/test/unit/user_upgrade_test.rb +++ b/test/unit/user_upgrade_test.rb @@ -31,12 +31,6 @@ class UserUpgradeTest < ActiveSupport::TestCase assert_equal("complete", @user_upgrade.status) end - should "log an account upgrade modaction" do - assert_difference("ModAction.user_account_upgrade.count") do - @user_upgrade.process_upgrade!("paid") - end - end - should "send the recipient a dmail" do assert_difference("@user_upgrade.recipient.dmails.received.count") do @user_upgrade.process_upgrade!("paid")