pundit: convert bans to pundit.

This commit is contained in:
evazion
2020-03-17 22:47:49 -05:00
parent ff1d71af2e
commit 3d72e62c77
6 changed files with 121 additions and 152 deletions

View File

@@ -10,51 +10,96 @@ class BansControllerTest < ActionDispatch::IntegrationTest
end
end
should "get the new page" do
get_auth new_ban_path, @mod
assert_response :success
end
should "get the edit page" do
get_auth edit_ban_path(@ban.id), @mod
assert_response :success
end
should "get the show page" do
get_auth ban_path(@ban.id), @mod
assert_response :success
end
should "get the index page" do
get_auth bans_path, @mod
assert_response :success
end
should "search" do
get_auth bans_path(search: {user_name: @user.name}), @mod
assert_response :success
end
should "create a ban" do
assert_difference("Ban.count", 1) do
post_auth bans_path, @mod, params: {ban: {duration: 60, reason: "xxx", user_id: @user.id}}
context "new action" do
should "render" do
get_auth new_ban_path, @mod
assert_response :success
end
ban = Ban.last
assert_redirected_to(ban_path(ban))
end
should "update a ban" do
put_auth ban_path(@ban.id), @mod, params: {ban: {reason: "xxx", duration: 60}}
@ban.reload
assert_equal("xxx", @ban.reason)
assert_redirected_to(ban_path(@ban))
end
should "destroy a ban" do
assert_difference("Ban.count", -1) do
delete_auth ban_path(@ban.id), @mod
context "edit action" do
should "render" do
get_auth edit_ban_path(@ban.id), @mod
assert_response :success
end
end
context "show action" do
should "render" do
get_auth ban_path(@ban.id), @mod
assert_response :success
end
end
context "index action" do
should "render" do
get_auth bans_path, @mod
assert_response :success
end
end
context "search action" do
should "render" do
get_auth bans_path(search: {user_name: @user.name}), @mod
assert_response :success
end
end
context "create action" do
should "allow mods to ban members" do
assert_difference("Ban.count", 1) do
post_auth bans_path, @mod, params: { ban: { duration: 60, reason: "xxx", user_id: @user.id }}
assert_response :redirect
assert_equal(true, @user.reload.is_banned?)
end
end
should "not allow mods to ban admins" do
assert_difference("Ban.count", 0) do
@admin = create(:admin_user)
post_auth bans_path, @mod, params: { ban: { duration: 60, reason: "xxx", user_id: @admin.id }}
assert_response 403
assert_equal(false, @admin.reload.is_banned?)
end
end
should "not allow mods to ban other mods" do
assert_difference("Ban.count", 0) do
@mod2 = create(:mod_user)
post_auth bans_path, @mod, params: { ban: { duration: 60, reason: "xxx", user_id: @mod2.id }}
assert_response 403
assert_equal(false, @mod2.reload.is_banned?)
end
end
should "not allow regular users to ban anyone" do
assert_difference("Ban.count", 0) do
post_auth bans_path, @user, params: { ban: { duration: 60, reason: "xxx", user_id: @mod.id }}
assert_response 403
assert_equal(false, @mod.reload.is_banned?)
end
end
end
context "update action" do
should "update a ban" do
put_auth ban_path(@ban.id), @mod, params: {ban: {reason: "xxx", duration: 60}}
assert_equal("xxx", @ban.reload.reason)
assert_redirected_to(ban_path(@ban))
end
end
context "destroy action" do
should "destroy a ban" do
assert_difference("Ban.count", -1) do
delete_auth ban_path(@ban.id), @mod
assert_redirected_to bans_path
end
end
assert_redirected_to(bans_path)
end
end
end