diff --git a/app/models/artist_url.rb b/app/models/artist_url.rb index 34c5e73f1..b4e4d9af5 100644 --- a/app/models/artist_url.rb +++ b/app/models/artist_url.rb @@ -20,11 +20,9 @@ class ArtistUrl < ApplicationRecord nil else url = url.sub(%r!^https://!, "http://") - url = url.sub(%r!^http://([^/]+)!i) { |domain| domain.downcase } url = url.sub(%r!^http://blog\d+\.fc2!, "http://blog.fc2") url = url.sub(%r!^http://blog-imgs-\d+\.fc2!, "http://blog.fc2") url = url.sub(%r!^http://blog-imgs-\d+-\w+\.fc2!, "http://blog.fc2") - # url = url.sub(%r!^(http://seiga.nicovideo.jp/user/illust/\d+)\?.+!, '\1/') url = url.sub(%r!^http://pictures.hentai-foundry.com//!, "http://pictures.hentai-foundry.com/") # the strategy won't always work for twitter because it looks for a status @@ -97,7 +95,15 @@ class ArtistUrl < ApplicationRecord end def normalize + # Perform some normalization with Addressable on the URL itself + # - Converts scheme and hostname to downcase + # - Converts unicode hostname to Punycode + uri = Addressable::URI.parse(url) + uri.site = uri.normalized_site + self.url = uri.to_s self.normalized_url = self.class.normalize(url) + rescue Addressable::URI::InvalidURIError + # Don't bother normalizing the URL if there is errors end def initialize_normalized_url @@ -112,9 +118,18 @@ class ArtistUrl < ApplicationRecord end end + def validate_scheme(uri) + errors[:url] << "'#{uri}' must begin with http:// or https:// " unless uri.scheme.in?(%w[http https]) + end + + def validate_hostname(uri) + errors[:url] << "'#{uri}' has a hostname '#{uri.host}' that does not contain a dot" unless uri.host&.include?('.') + end + def validate_url_format uri = Addressable::URI.parse(url) - errors[:url] << "'#{uri}' must begin with http:// or https:// " if !uri.scheme.in?(%w[http https]) + validate_scheme(uri) + validate_hostname(uri) rescue Addressable::URI::InvalidURIError => error errors[:url] << "'#{uri}' is malformed: #{error}" end diff --git a/test/unit/artist_url_test.rb b/test/unit/artist_url_test.rb index 776554646..fc4f22ba4 100644 --- a/test/unit/artist_url_test.rb +++ b/test/unit/artist_url_test.rb @@ -24,10 +24,18 @@ class ArtistUrlTest < ActiveSupport::TestCase end should "disallow invalid urls" do - url = FactoryBot.build(:artist_url, url: "www.example.com") + urls = [ + FactoryBot.build(:artist_url, url: "www.example.com"), + FactoryBot.build(:artist_url, url: ":www.example.com"), + FactoryBot.build(:artist_url, url: "http://http://www.example.com"), + ] - assert_equal(false, url.valid?) - assert_match(/must begin with http/, url.errors.full_messages.join) + assert_equal(false, urls[0].valid?) + assert_match(/must begin with http/, urls[0].errors.full_messages.join) + assert_equal(false, urls[1].valid?) + assert_match(/is malformed/, urls[1].errors.full_messages.join) + assert_equal(false, urls[2].valid?) + assert_match(/that does not contain a dot/, urls[2].errors.full_messages.join) end should "always add a trailing slash when normalized" do