jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

Fix #4014: Incorrect tag type counts on posts.

Browse Source
This commit is contained in:
evazion
2018-12-19 12:20:29 -06:00
parent 3adf24c0aa
commit 3e382bd831
2 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/models/tag.rb
View File

@@ -21,7 +21,8 @@ class Tag < ApplicationRecord
validates :name, uniqueness: true, tag_name: true, on: :create validates :name, uniqueness: true, tag_name: true, on: :create
validates_inclusion_of :category, in: TagCategory.category_ids validates_inclusion_of :category, in: TagCategory.category_ids
after_save :update_category_cache, if: ->(rec) { rec.saved_change_to_attribute?(:category)} before_save :update_category_cache, if: :category_changed?
before_save :update_category_post_counts, if: :category_changed?
module ApiMethods module ApiMethods
def to_legacy_json def to_legacy_json

11
test/unit/tag_test.rb
View File

@@ -208,6 +208,17 @@ class TagTest < ActiveSupport::TestCase
assert_equal(0, tag.reload.category) assert_equal(0, tag.reload.category)
end end
should "update post tag counts when the category is changed" do
post = FactoryBot.create(:post, tag_string: "test")
assert_equal(1, post.tag_count_general)
assert_equal(0, post.tag_count_character)
tag = Tag.find_or_create_by_name("char:test")
post.reload
assert_equal(0, post.tag_count_general)
assert_equal(1, post.tag_count_character)
end
should "be created when one doesn't exist" do should "be created when one doesn't exist" do
assert_difference("Tag.count", 1) do assert_difference("Tag.count", 1) do
tag = Tag.find_or_create_by_name("hoge") tag = Tag.find_or_create_by_name("hoge")