fixed user tests

test/unit/favorite_test.rb

@@ -6,6 +6,7 @@ class FavoriteTest < ActiveSupport::TestCase
     CurrentUser.user = user
     CurrentUser.ip_addr = "127.0.0.1"
     MEMCACHE.flush_all
+    Favorite # need to force loading the favorite model
   end
   
   teardown do
@@ -23,30 +24,26 @@ class FavoriteTest < ActiveSupport::TestCase
       p1.add_favorite(user1)
       p2.add_favorite(user1)
       p1.add_favorite(user2)
-    
-      favorites = user1.favorite_posts
-      assert_equal(2, favorites.size)
-      assert_equal(p2.id, favorites[0].id)
-      assert_equal(p1.id, favorites[1].id)
       
-      favorites = user2.favorite_posts
-      assert_equal(1, favorites.size)
-      assert_equal(p1.id, favorites[0].id)
+      favorites = user1.favorites.order("id desc")
+      assert_equal(2, favorites.count)
+      assert_equal(p2.id, favorites[0].post_id)
+      assert_equal(p1.id, favorites[1].post_id)
+      
+      favorites = user2.favorites.order("id desc")
+      assert_equal(1, favorites.count)
+      assert_equal(p1.id, favorites[0].post_id)
     end
     
-    should "filter before a given id" do
+    should "not allow duplicates" do
       user1 = Factory.create(:user)
       p1 = Factory.create(:post)
       p2 = Factory.create(:post)
-      p3 = Factory.create(:post)
+      
       p1.add_favorite(user1)
-      p2.add_favorite(user1)
-      p3.add_favorite(user1)
-      favorites = user1.favorite_posts
-      favorites = user1.favorite_posts(:before_id => favorites.first.favorite_id)
-      assert_equal(2, favorites.count)
-      assert_equal(p2.id, favorites[0].id)
-      assert_equal(p1.id, favorites[1].id)
+      p1.add_favorite(user1)
+      
+      assert_equal(1, user1.favorites.count)
     end
   end
 end