Post#expunge!: run callbacks when reparenting children.

* Set parent IDs with `update` instead of `update_column` /
  `update_all` when reparenting children. This fixes it so that new post
  versions are saved and the has_children flag is set on the new parent.

* Slightly simplify logic of update_children_on_destroy: the single
  child case is subsumed by the multi-child case.
This commit is contained in:
evazion
2017-07-20 21:53:53 -05:00
parent fbee7f6912
commit 44f6673d94
2 changed files with 40 additions and 22 deletions

View File

@@ -1314,17 +1314,14 @@ class Post < ApplicationRecord
end
def update_children_on_destroy
if children.size == 0
# do nothing
elsif children.size == 1
children.first.update_column(:parent_id, nil)
else
cached_children = children
eldest = cached_children[0]
siblings = cached_children[1..-1]
eldest.update_column(:parent_id, nil)
Post.where(:id => siblings.map(&:id)).update_all(:parent_id => eldest.id)
end
return unless children.present?
eldest = children[0]
siblings = children[1..-1]
eldest.update(parent_id: nil)
Post.where(id: siblings).find_each { |p| p.update(parent_id: eldest.id) }
# Post.where(id: siblings).update(parent_id: eldest.id) # XXX rails 5
end
def update_parent_on_save