bubble up upload validation errors during replacement

restore missing UploadService::Replacer tests
addresses #3761
This commit is contained in:
Albert Yi
2018-06-25 14:53:06 -07:00
parent 24f8710877
commit 4836804cae
2 changed files with 397 additions and 3 deletions

View File

@@ -311,16 +311,16 @@ class UploadService
if Utils.is_downloadable?(source)
CurrentUser.as_system do
if Post.tag_match("source:#{source}").exists?
return
raise ActiveRecord::RecordNotUnique.new("A post with source #{source} already exists")
end
end
if Upload.where(source: source, status: "completed").exists?
return
raise ActiveRecord::RecordNotUnique.new("A completed upload with source #{source} already exists")
end
if Upload.where(source: source).where("status like ?", "error%").exists?
return
raise ActiveRecord::RecordNotUnique.new("An errored upload with source #{source} already exists")
end
end