artists: fix ban/unban actions.

Fix the ban! and unban! methods to:

* Lock the artist while it is being banned or unbanned.
* Perform the edits as a mass update, so that the posts are updated in parallel.
* Edit the artist as the banner rather than as the current user.
* Soft delete the banned_artist implication when an artist is unbanned instead of hard deleting it.
* Ignore the banned_artist implication if it's deleted.

test/functional/artists_controller_test.rb

@@ -132,12 +132,12 @@ class ArtistsControllerTest < ActionDispatch::IntegrationTest
 
     context "unban action" do
       should "unban an artist" do
-        as(@admin) { @artist.ban!(banner: @admin) }
+        @artist.ban!(@admin)
         put_auth unban_artist_path(@artist.id), @admin
 
         assert_redirected_to(@artist)
         assert_equal(false, @artist.reload.is_banned?)
-        assert_equal(false, TagImplication.exists?(antecedent_name: @artist.name, consequent_name: "banned_artist"))
+        assert_equal(true, TagImplication.deleted.exists?(antecedent_name: @artist.name, consequent_name: "banned_artist"))
       end
     end
 

test/unit/artist_test.rb

@@ -63,7 +63,7 @@ class ArtistTest < ActiveSupport::TestCase
         @artist = FactoryBot.create(:artist, :name => "aaa")
         @post = FactoryBot.create(:post, :tag_string => "aaa")
         @admin = FactoryBot.create(:admin_user)
-        @artist.ban!(banner: @admin)
+        @artist.ban!(@admin)
         perform_enqueued_jobs
         @post.reload
       end
@@ -72,15 +72,17 @@ class ArtistTest < ActiveSupport::TestCase
         assert_equal(true, @artist.reload.is_banned?)
         assert_equal(true, @post.reload.is_banned?)
         assert_equal(true, @artist.versions.last.is_banned?)
+        assert_equal(true, TagImplication.active.exists?(antecedent_name: @artist.name, consequent_name: "banned_artist"))
 
-        assert_difference("TagImplication.count", -1) do
-          @artist.unban!
-        end
+        @artist.unban!(@admin)
 
         assert_equal(false, @artist.reload.is_banned?)
         assert_equal(false, @post.reload.is_banned?)
         assert_equal(false, @artist.versions.last.is_banned?)
         assert_equal("aaa", @post.tag_string)
+        assert_equal(false, TagImplication.active.exists?(antecedent_name: @artist.name, consequent_name: "banned_artist"))
+        assert_equal(true, TagImplication.deleted.exists?(antecedent_name: @artist.name, consequent_name: "banned_artist"))
+        assert_equal(true, ModAction.artist_unban.exists?(subject: @artist))
       end
 
       should "ban the post" do
@@ -106,8 +108,18 @@ class ArtistTest < ActiveSupport::TestCase
       end
 
       should "update the artist history" do
+        assert_equal(true, @artist.reload.is_banned?)
         assert_equal(true, @artist.versions.last.is_banned?)
       end
+
+      should "tag the posts" do
+        assert_equal(true, @post.reload.is_banned?)
+        assert_equal(true, @post.has_tag?("banned_artist"))
+      end
+
+      should "create a mod action" do
+        assert_equal(true, ModAction.artist_ban.exists?(subject: @artist))
+      end
     end
 
     should "normalize its name" do

test/unit/post_test.rb

@@ -384,11 +384,7 @@ class PostTest < ActiveSupport::TestCase
 
       context "with a banned artist" do
         setup do
-          CurrentUser.scoped(FactoryBot.create(:admin_user)) do
-            @artist = FactoryBot.create(:artist)
-            @artist.ban!
-            perform_enqueued_jobs
-          end
+          @artist = create(:artist, is_banned: true)
           @post = FactoryBot.create(:post, :tag_string => @artist.name)
         end