From 51867a8c64ffad4b3762f9836bf633f055b9394f Mon Sep 17 00:00:00 2001 From: r888888888 Date: Mon, 9 Oct 2017 16:59:56 -0700 Subject: [PATCH] truncate urls on display on post replacements page #3322 --- app/helpers/application_helper.rb | 10 ++++++++-- app/views/post_replacements/index.html.erb | 4 ++-- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/app/helpers/application_helper.rb b/app/helpers/application_helper.rb index 95b2e01ec..23e1bc08f 100644 --- a/app/helpers/application_helper.rb +++ b/app/helpers/application_helper.rb @@ -93,9 +93,15 @@ module ApplicationHelper time_tag(time.strftime("%Y-%m-%d %H:%M"), time) end - def external_link_to(url) + def external_link_to(url, options = {}) + if options[:truncate] + text = truncate(url, length: options[:truncate]) + else + text = url + end + if url =~ %r!\Ahttps?://!i - link_to url, url, {rel: :nofollow} + link_to text, url, {rel: :nofollow} else url end diff --git a/app/views/post_replacements/index.html.erb b/app/views/post_replacements/index.html.erb index c8a783c28..8ad4e9b6f 100644 --- a/app/views/post_replacements/index.html.erb +++ b/app/views/post_replacements/index.html.erb @@ -25,11 +25,11 @@
Original Source
-
<%= external_link_to post_replacement.original_url %>
+
<%= external_link_to post_replacement.original_url, truncate: 64 %>
Replacement Source
<% if post_replacement.replacement_url.present? %> - <%= external_link_to post_replacement.replacement_url %> + <%= external_link_to post_replacement.replacement_url, truncate: 64 %> <% else %> file <% end %>