maintenance: break maintenance tasks into individual jobs.

Break the hourly/daily/weekly/monthly maintenance tasks down into
individual delayed jobs. This way if one task fails, it won't prevent
other tasks from running. Also, jobs can be run in parallel, and can be
individually retried if they fail.

test/jobs/prune_bans_job_test.rb

@@ -0,0 +1,18 @@
+require 'test_helper'
+
+class PruneBansJobTest < ActiveJob::TestCase
+  context "PruneBansJob" do
+    should "prune all expired bans" do
+      @expired_ban = travel_to(1.month.ago) { create(:ban, duration: 1.week) }
+      @unexpired_ban = create(:ban, duration: 1.week)
+
+      assert_equal(true, @expired_ban.user.is_banned?)
+      assert_equal(true, @unexpired_ban.user.is_banned?)
+
+      PruneBansJob.perform_now
+
+      assert_equal(false, @expired_ban.user.reload.is_banned?)
+      assert_equal(true, @unexpired_ban.user.reload.is_banned?)
+    end
+  end
+end

test/jobs/prune_posts_job_test.rb

@@ -0,0 +1,22 @@
+require 'test_helper'
+
+class PrunePostsJobTest < ActiveJob::TestCase
+  context "PrunePostsJob" do
+    should "prune expired posts" do
+      @pending = create(:post, is_pending: true, created_at: 5.days.ago)
+      @flagged = create(:post, is_flagged: true, created_at: 5.days.ago)
+      @appealed = create(:post, is_deleted: true, created_at: 5.days.ago)
+
+      @flag = create(:post_flag, post: @flagged, created_at: 4.days.ago)
+      @appeal = create(:post_appeal, post: @appealed, created_at: 4.days.ago)
+
+      PrunePostsJob.perform_now
+
+      assert_equal(true, @pending.reload.is_deleted?)
+      assert_equal(true, @flagged.reload.is_deleted?)
+      assert_equal(true, @appealed.reload.is_deleted?)
+      assert_equal(true, @flag.reload.succeeded?)
+      assert_equal(true, @appeal.reload.rejected?)
+    end
+  end
+end

test/jobs/prune_rate_limits_job_test.rb

@@ -0,0 +1,13 @@
+require 'test_helper'
+
+class PruneRateLimitsJobTest < ActiveJob::TestCase
+  context "PruneRateLimitsJob" do
+    should "prune all stale rate limits" do
+      travel_to(2.hours.ago) { create(:rate_limit) }
+
+      assert_equal(1, RateLimit.count)
+      PruneRateLimitsJob.perform_now
+      assert_equal(0, RateLimit.count)
+    end
+  end
+end

test/jobs/prune_uploads_job_test.rb

@@ -0,0 +1,19 @@
+require 'test_helper'
+
+class PruneUploadsJobTest < ActiveJob::TestCase
+  context "PruneUploadsJob" do
+    should "prune all old uploads" do
+      @uploader = create(:user)
+
+      as(@uploader) do
+        @completed_upload = travel_to(2.hours.ago) { create(:upload, uploader: @uploader, status: "completed") }
+        @stale_upload = travel_to(2.days.ago) { create(:upload, uploader: @uploader, status: "preprocessed") }
+        @failed_upload = travel_to(4.days.ago) { create(:upload, uploader: @uploader, status: "error") }
+      end
+
+      assert_equal(3, Upload.count)
+      PruneUploadsJob.perform_now
+      assert_equal(0, Upload.count)
+    end
+  end
+end

test/jobs/regenerate_post_counts_job_test.rb

@@ -0,0 +1,18 @@
+require 'test_helper'
+
+class RegeneratePostCountsJobTest < ActiveJob::TestCase
+  context "RegeneratePostCountsJob" do
+    should "regenerate all incorrect tag post counts" do
+      tag1 = create(:tag, name: "touhou", post_count: -10)
+      tag2 = create(:tag, name: "bkub", post_count: 10)
+      tag3 = create(:tag, name: "chen", post_count: 10)
+      post = create(:post, tag_string: "touhou bkub")
+
+      RegeneratePostCountsJob.perform_now
+
+      assert_equal(1, Tag.find_by_name!("touhou").post_count)
+      assert_equal(1, Tag.find_by_name!("bkub").post_count)
+      assert_equal(0, Tag.find_by_name!("chen").post_count)
+    end
+  end
+end

test/unit/danbooru_maintenance_test.rb

@@ -3,38 +3,36 @@ require 'test_helper'
 class DanbooruMaintenanceTest < ActiveSupport::TestCase
   context "hourly maintenance" do
     should "work" do
-      assert_nothing_raised { DanbooruMaintenance.hourly }
-    end
-
-    should "prune expired posts" do
-      @pending = create(:post, is_pending: true, created_at: 5.days.ago)
-      @flagged = create(:post, is_flagged: true, created_at: 5.days.ago)
-      @appealed = create(:post, is_deleted: true, created_at: 5.days.ago)
-
-      @flag = create(:post_flag, post: @flagged, created_at: 4.days.ago)
-      @appeal = create(:post_appeal, post: @appealed, created_at: 4.days.ago)
-
-      DanbooruMaintenance.hourly
-
-      assert_equal(true, @pending.reload.is_deleted?)
-      assert_equal(true, @flagged.reload.is_deleted?)
-      assert_equal(true, @appealed.reload.is_deleted?)
-      assert_equal(true, @flag.reload.succeeded?)
-      assert_equal(true, @appeal.reload.rejected?)
+      assert_nothing_raised do
+        DanbooruMaintenance.hourly
+        perform_enqueued_jobs
+      end
     end
   end
 
-  context "hourly maintenance" do
-    context "when pruning bans" do
-      should "clear the is_banned flag for users who are no longer banned" do
-        banner = FactoryBot.create(:admin_user)
-        user = FactoryBot.create(:user)
+  context "daily maintenance" do
+    should "work" do
+      assert_nothing_raised do
+        DanbooruMaintenance.daily
+        perform_enqueued_jobs
+      end
+    end
+  end
 
-        as(banner) { create(:ban, user: user, banner: banner, duration: 1) }
+  context "weekly maintenance" do
+    should "work" do
+      assert_nothing_raised do
+        DanbooruMaintenance.weekly
+        perform_enqueued_jobs
+      end
+    end
+  end
 
-        assert_equal(true, user.reload.is_banned)
-        travel_to(2.days.from_now) { DanbooruMaintenance.daily }
-        assert_equal(false, user.reload.is_banned)
+  context "monthly maintenance" do
+    should "work" do
+      assert_nothing_raised do
+        DanbooruMaintenance.monthly
+        perform_enqueued_jobs
       end
     end
   end

test/unit/tag_test.rb

@@ -194,19 +194,4 @@ class TagTest < ActiveSupport::TestCase
       end
     end
   end
-
-  context "A tag with an incorrect post count" do
-    should "be fixed" do
-      tag1 = FactoryBot.create(:tag, name: "touhou", post_count: -10)
-      tag2 = FactoryBot.create(:tag, name: "bkub", post_count: 10)
-      tag3 = FactoryBot.create(:tag, name: "chen", post_count: 10)
-      post = FactoryBot.create(:post, tag_string: "touhou bkub")
-
-      tags = Tag.regenerate_post_counts!
-      assert_equal(3, tags.size)
-      assert_equal(1, tag1.reload.post_count)
-      assert_equal(1, tag2.reload.post_count)
-      assert_equal(0, tag3.reload.post_count)
-    end
-  end
 end