reports: fix exception when using period option and filtering by association.
Fix an exception in reports like this: * https://betabooru.donmai.us/reports/posts?search[period]=day&search[uploader][name]=evazion Caused by the `search` method doing a left join instead of a subquery when filtering by a belongs to association.
This commit is contained in:
@@ -643,7 +643,15 @@ module Searchable
|
||||
end
|
||||
|
||||
if parameter_hash?(params[attr])
|
||||
relation = visible(relation, attr).includes(attr).references(attr).where(attr => model.visible(current_user).search(params[attr], current_user).reorder(nil))
|
||||
if association.belongs_to?
|
||||
foreign_key = association.foreign_key
|
||||
primary_key = association.association_primary_key
|
||||
else
|
||||
foreign_key = association.association_primary_key
|
||||
primary_key = association.foreign_key
|
||||
end
|
||||
|
||||
relation = visible(relation, attr).where(foreign_key => model.visible(current_user).search(params[attr], current_user).reorder(nil).select(primary_key))
|
||||
end
|
||||
|
||||
relation
|
||||
|
||||
Reference in New Issue
Block a user