jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

maintenance: fix post pruning test.

Browse Source 
Test mistakenly passed because we used `assert(a, b)` instead of
`assert_equal(a, b)`.
This commit is contained in:
evazion
2020-08-07 08:53:38 -05:00
parent dd44dce597
commit 56ba6c2c58
2 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/logical/danbooru_maintenance.rb
View File

@@ -6,7 +6,7 @@ module DanbooruMaintenance
end end
def daily def daily
safely { PostPruner.new.prune! } safely { PostPruner.prune! }
safely { Delayed::Job.where('created_at < ?', 45.days.ago).delete_all } safely { Delayed::Job.where('created_at < ?', 45.days.ago).delete_all }
safely { PostDisapproval.prune! } safely { PostDisapproval.prune! }
safely { regenerate_post_counts! } safely { regenerate_post_counts! }

15
test/unit/danbooru_maintenance_test.rb
View File

@@ -7,13 +7,20 @@ class DanbooruMaintenanceTest < ActiveSupport::TestCase
end end
should "prune expired posts" do should "prune expired posts" do
@pending = FactoryBot.create(:post, is_pending: true, created_at: 4.days.ago) @pending = create(:post, is_pending: true, created_at: 5.days.ago)
@flagged = FactoryBot.create(:post, is_flagged: true, created_at: 4.days.ago) @flagged = create(:post, is_flagged: true, created_at: 5.days.ago)
@appealed = create(:post, is_deleted: true, created_at: 5.days.ago)
@flag = create(:post_flag, post: @flagged, created_at: 4.days.ago)
@appeal = create(:post_appeal, post: @appealed, created_at: 4.days.ago)
DanbooruMaintenance.daily DanbooruMaintenance.daily
assert(true, @pending.reload.is_deleted) assert_equal(true, @pending.reload.is_deleted?)
assert(true, @flagged.reload.is_deleted) assert_equal(true, @flagged.reload.is_deleted?)
assert_equal(true, @appealed.reload.is_deleted?)
assert_equal(true, @flag.reload.succeeded?)
assert_equal(true, @appeal.reload.rejected?)
end end
context "when pruning bans" do context "when pruning bans" do