pundit: convert users to pundit.

test/functional/admin/users_controller_test.rb

@@ -20,8 +20,7 @@ class Admin::UsersControllerTest < ActionDispatch::IntegrationTest
         should "succeed" do
           put_auth admin_user_path(@user), @mod, params: {:user => {:level => "30"}}
           assert_redirected_to(edit_admin_user_path(@user))
-          @user.reload
-          assert_equal(30, @user.level)
+          assert_equal(30, @user.reload.level)
           assert_equal(@mod.id, @user.inviter_id)
         end
 
@@ -29,8 +28,7 @@ class Admin::UsersControllerTest < ActionDispatch::IntegrationTest
           should "fail" do
             put_auth admin_user_path(@user), @mod, params: {:user => {:level => "50"}}
             assert_response(403)
-            @user.reload
-            assert_equal(20, @user.level)
+            assert_equal(20, @user.reload.level)
           end
         end
       end
@@ -39,8 +37,7 @@ class Admin::UsersControllerTest < ActionDispatch::IntegrationTest
         should "fail" do
           put_auth admin_user_path(@admin), @mod, params: {:user => {:level => "30"}}
           assert_response(403)
-          @admin.reload
-          assert_equal(50, @admin.level)
+          assert_equal(50, @admin.reload.level)
         end
       end
     end

test/functional/user_upgrades_controller_test.rb

@@ -0,0 +1,19 @@
+require 'test_helper'
+
+class UserUpgradesControllerTest < ActionDispatch::IntegrationTest
+  context "The user upgrades controller" do
+    context "new action" do
+      should "render" do
+        get new_user_upgrade_path
+        assert_response :success
+      end
+    end
+
+    context "show action" do
+      should "render" do
+        get_auth user_upgrade_path, create(:user)
+        assert_response :success
+      end
+    end
+  end
+end

test/functional/users_controller_test.rb

@@ -186,14 +186,12 @@ class UsersControllerTest < ActionDispatch::IntegrationTest
       end
 
       context "changing the level" do
-        setup do
-          @cuser = create(:user)
-        end
-
         should "not work" do
+          @cuser = create(:user)
           put_auth user_path(@user), @cuser, params: {:user => {:level => 40}}
-          @user.reload
-          assert_equal(20, @user.level)
+
+          assert_response 403
+          assert_equal(20, @user.reload.level)
         end
       end