jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

table builder: fix various incorrect css classes.

Browse Source 
Change calling convention to explicitly indicate whether the attributes
are for the <th> element or the <td> element. Fixes various cases where
the two were mixed up.

* Fix .col-expand classes not being set correctly on the /post_versions,
  /pool_versions, and /notes pages.

* Fix .updater and .updated-at classes not being set correctly on the
  /forum_topics page.

* Fix the name param being ignored (noticeable in the post count field
  on the /tags page).

* Don't pass empty string when column has no name.
This commit is contained in:
evazion
2020-01-07 01:21:42 -06:00
parent cdb42aad66
commit 5c913d8ad1
36 changed files with 61 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/views/bans/index.html.erb
View File

@@ -12,7 +12,7 @@
<% t.column "Duration" do |ban| %>
<%= humanized_duration(ban.created_at, ban.expires_at) %>
<% end %>
<% t.column "Reason", nil, {class: "col-expand"} do |ban| %>
<% t.column "Reason", td: {class: "col-expand"} do |ban| %>
<div class="prose">
<%= format_text ban.reason %>
</div>
@@ -22,7 +22,7 @@
<%= link_to "»", bans_path(search: { banner_name: ban.banner.name }) %>
<div><%= time_ago_in_words_tagged(ban.created_at) %></div>
<% end %>
<% t.column "" do |ban| %>
<% t.column do |ban| %>
<% if CurrentUser.is_moderator? %>
<%= link_to "Edit", edit_ban_path(ban) %>
| <%= link_to "Delete", ban_path(ban), :method => :delete, :remote => true %>