table builder: fix various incorrect css classes.

Change calling convention to explicitly indicate whether the attributes
are for the <th> element or the <td> element. Fixes various cases where
the two were mixed up.

* Fix .col-expand classes not being set correctly on the /post_versions,
  /pool_versions, and /notes pages.

* Fix .updater and .updated-at classes not being set correctly on the
  /forum_topics page.

* Fix the name param being ignored (noticeable in the post count field
  on the /tags page).

* Don't pass empty string when column has no name.
This commit is contained in:
evazion
2020-01-07 01:21:42 -06:00
parent cdb42aad66
commit 5c913d8ad1
36 changed files with 61 additions and 61 deletions

View File

@@ -7,11 +7,11 @@
<% t.column "Name" do |job| %>
<%= raw print_name(job) %>
<% end %>
<% t.column "Handler", nil, {class: "col-expand"} do |job| %>
<% t.column "Handler", td: {class: "col-expand"} do |job| %>
<%= raw print_handler(job) %>
<% end %>
<% t.column :attempts %>
<% t.column "Last error", nil, {class: "col-expand"} do |job| %>
<% t.column "Last error", td: {class: "col-expand"} do |job| %>
<% if job.last_error %>
<%= job.last_error.split(/\n/)[0] %>
<%= job.last_error.split(/\n/)[1..-1].grep(/releases/).join("\n") %>
@@ -23,7 +23,7 @@
<% t.column "Run at" do |job| %>
<%= time_ago_in_words_tagged(job.run_at) %>
<% end %>
<% t.column "" do |job| %>
<% t.column do |job| %>
<% if CurrentUser.is_admin? %>
<% if job.locked_at? %>
Running