table builder: fix various incorrect css classes.

Change calling convention to explicitly indicate whether the attributes
are for the <th> element or the <td> element. Fixes various cases where
the two were mixed up.

* Fix .col-expand classes not being set correctly on the /post_versions,
  /pool_versions, and /notes pages.

* Fix .updater and .updated-at classes not being set correctly on the
  /forum_topics page.

* Fix the name param being ignored (noticeable in the post count field
  on the /tags page).

* Don't pass empty string when column has no name.
This commit is contained in:
evazion
2020-01-07 01:21:42 -06:00
parent cdb42aad66
commit 5c913d8ad1
36 changed files with 61 additions and 61 deletions

View File

@@ -15,7 +15,7 @@
<%= link_to "Forum ##{forum_post_vote.forum_post_id}", forum_post_vote.forum_post %>
<%= link_to "»", forum_post_votes_path(search: { forum_post_id: forum_post_vote.forum_post_id }) %>
<% end %>
<% t.column "Forum Topic", nil, {class: "col-expand"} do |forum_post_vote| %>
<% t.column "Forum Topic", td: {class: "col-expand"} do |forum_post_vote| %>
<%= link_to forum_post_vote.forum_post.topic.title, forum_post_vote.forum_post.topic %>
<% end %>
<% t.column "Score" do |forum_post_vote| %>
@@ -31,7 +31,7 @@
<%= link_to "»", forum_post_votes_path(search: { creator_name: forum_post_vote.creator.name }) %>
<div><%= time_ago_in_words_tagged(forum_post_vote.created_at) %></div>
<% end %>
<% t.column "" do |forum_post_vote| %>
<% t.column do |forum_post_vote| %>
<% if forum_post_vote.creator == CurrentUser.user %>
<%= link_to "unvote", forum_post_vote_path(forum_post_vote, format: "js"), remote: true, method: :delete %>
<% end %>