jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

table builder: fix various incorrect css classes.

Browse Source 
Change calling convention to explicitly indicate whether the attributes
are for the <th> element or the <td> element. Fixes various cases where
the two were mixed up.

* Fix .col-expand classes not being set correctly on the /post_versions,
  /pool_versions, and /notes pages.

* Fix .updater and .updated-at classes not being set correctly on the
  /forum_topics page.

* Fix the name param being ignored (noticeable in the post count field
  on the /tags page).

* Don't pass empty string when column has no name.
This commit is contained in:
evazion
2020-01-07 01:21:42 -06:00
parent cdb42aad66
commit 5c913d8ad1
36 changed files with 61 additions and 61 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/views/post_versions/_listing.html.erb
View File

@@ -5,7 +5,7 @@
<%= table_for @post_versions, {id: "post-versions-table", class: "striped autofit"} do |t| %>
<% if CurrentUser.user.is_builder? %>
<% t.column tag.label(tag.input type: :checkbox, id: "post-version-select-all-checkbox", class: "post-version-select-checkbox"), { class: "post-version-select-column" } do |post_version| %>
<% t.column tag.label(tag.input type: :checkbox, id: "post-version-select-all-checkbox", class: "post-version-select-checkbox"), th: { class: "post-version-select-column" }, td: { class: "post-version-select-column" } do |post_version| %>
<input type="checkbox" class="post-version-select-checkbox" <%= "disabled" unless post_version.can_undo?(CurrentUser.user) %>>
<% end %>
<% end %>
@@ -17,7 +17,7 @@
<% t.column "Version" do |post_version| %>
<%= link_to "#{post_version.post_id}.#{post_version.version}", post_versions_path(search: { post_id: post_version.post_id }, anchor: "post-version-#{post_version.id}") %>
<% end %>
<% t.column "Tags", {class: "col-expand"} do |post_version| %>
<% t.column "Tags", td: {class: "col-expand"} do |post_version| %>
<%= post_version_diff(post_version) %>
<% end %>
<% t.column "Updated" do |post_version| %>
@@ -30,7 +30,7 @@
<% end %>
</div>
<% end %>
<% t.column "" do |post_version| %>
<% t.column do |post_version| %>
<% if post_version.can_undo?(CurrentUser.user) %>
<%= link_to "Undo", undo_post_version_path(post_version), method: :put, remote: true, class: "post-version-undo-link" %>
<% end %>