users: remove confirmation when changing username.

app/models/user_name_change_request.rb

@@ -5,7 +5,6 @@ class UserNameChangeRequest < ApplicationRecord
   belongs_to :approver, class_name: "User", optional: true
 
   validate :not_limited, on: :create
-  validates :desired_name, user_name: true, confirmation: true, on: :create
   validates :original_name, presence: true
   validates :desired_name, presence: true
 

app/policies/user_name_change_request_policy.rb

@@ -10,6 +10,6 @@ class UserNameChangeRequestPolicy < ApplicationPolicy
   end
 
   def permitted_attributes
-    [:desired_name, :desired_name_confirmation]
+    [:desired_name]
   end
 end

app/views/user_name_change_requests/new.html.erb

@@ -27,8 +27,7 @@
 
     <%= edit_form_for(@change_request) do |f| %>
       <%= f.input :desired_name, label: "New name" %>
-      <%= f.input :desired_name_confirmation, label: "Confirm name" %>
-      <%= f.submit "Submit", "data-confirm": "Are you sure you want to change your name?" %>
+      <%= f.submit "Submit" %>
     <% end %>
   </div>
 </div>

test/functional/user_name_change_requests_controller_test.rb

@@ -23,7 +23,7 @@ class UserNameChangeRequestsControllerTest < ActionDispatch::IntegrationTest
 
     context "create action" do
       should "work" do
-        post_auth user_name_change_requests_path, @user, params: { user_name_change_request: { desired_name: "zun", desired_name_confirmation: "zun" }}
+        post_auth user_name_change_requests_path, @user, params: { user_name_change_request: { desired_name: "zun" }}
 
         assert_redirected_to profile_path
         assert_equal("zun", @user.reload.name)