From 5e23861bea7132c07b79147b7bcd716678fcba4a Mon Sep 17 00:00:00 2001 From: evazion Date: Thu, 25 Jun 2020 16:28:18 -0500 Subject: [PATCH] simple form: enable HTML5 maxlength validations. Makes it so that models that have maximum length validations will add maxlength attributes to form fields. This includes flag reasons, appeal reasons, and forum topic titles. Partially fixes #4519 (Add "n/m characters remaining" character counter to the appeal reason). https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/maxlength --- config/initializers/simple_form.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/config/initializers/simple_form.rb b/config/initializers/simple_form.rb index 9fd871574..bde646c6e 100644 --- a/config/initializers/simple_form.rb +++ b/config/initializers/simple_form.rb @@ -39,7 +39,7 @@ SimpleForm.setup do |config| # Calculates maxlength from length validations for string inputs # and/or database column lengths - b.optional :maxlength + b.use :maxlength # Calculate minlength from length validations for string inputs b.optional :minlength @@ -129,7 +129,7 @@ SimpleForm.setup do |config| # in this configuration, which is recommended due to some quirks from different browsers. # To stop SimpleForm from generating the novalidate option, enabling the HTML5 validations, # change this configuration to true. - config.browser_validations = false + config.browser_validations = true # Custom mappings for input types. This should be a hash containing a regexp # to match as key, and the input type that will be used when the field name