jaculabilis/danbooru
1
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

BURs: fix exception when estimating post counts of category changes.

Browse Source 
Fix an error in operator precedence:

> sum + Tag.find_by_name(token[1]).try(:post_count) || 0

This was treated as `(sum + X) || 0` not `sum + (X || 0)` as intended.
This failed when X was nil.
This commit is contained in:
evazion
2019-12-10 00:49:24 -06:00
parent e906b902d8
commit 6196f7ba67
1 changed files with 7 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
app/logical/alias_and_implication_importer.rb
View File

@@ -80,24 +80,20 @@ class AliasAndImplicationImporter
def estimate_update_count def estimate_update_count
tokens = self.class.tokenize(text) tokens = self.class.tokenize(text)
tokens.inject(0) do |sum, token| tokens.map do |token|
case token[0] case token[0]
when :create_alias when :create_alias
sum + TagAlias.new(antecedent_name: token[1], consequent_name: token[2]).estimate_update_count TagAlias.new(antecedent_name: token[1], consequent_name: token[2]).estimate_update_count
when :create_implication when :create_implication
sum + TagImplication.new(antecedent_name: token[1], consequent_name: token[2]).estimate_update_count TagImplication.new(antecedent_name: token[1], consequent_name: token[2]).estimate_update_count
when :mass_update when :mass_update
sum + TagBatchChangeJob.estimate_update_count(token[1], token[2]) TagBatchChangeJob.estimate_update_count(token[1], token[2])
when :change_category when :change_category
sum + Tag.find_by_name(token[1]).try(:post_count) || 0 Tag.find_by_name(token[1]).try(:post_count) || 0
else else
sum + 0 0
end end
end end.sum
end end
def affected_tags def affected_tags